Solution issue 493 and 495 2nd try #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second try to solve issues #493 and #495.
A new option has also been defined : forcedAspectRatio. Through this option, you can now force the height of the chart as a percentage of the width. This is particulary interesting when the width is defined as a percentage of his container.
See new chapter in wiki documentation : https://github.com/FVANCOP/ChartNew.js/wiki/125_Canvas_dimensions
See also https://github.com/FVANCOP/ChartNew.js/wiki/100_015_ResponsiveChart#forcedaspectratio