Replace cmake based unit test action with platformio #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbancroft
changed the title
adbancroft
changed the title
FabioBatSilva
requested changes
Sep 25, 2025
adbancroft
force-pushed
the
pio_actions
branch
2 times, most recently
from
85aeb74 to
80ff7fc
Compare
This was referenced Sep 28, 2025
|
@FabioBatSilva Would you accept this PR? Or are there other changes needed? |
|
It looks ok but I haven't had the chance to look into the root cause for the failing test yet. |
|
Since this PR isn't the root cause, could you accept it? I have a bunch of follow up PR's waiting on this & #72. |
No, I'm not sure what the root cause is and don't think disabling is a viable solution. |
|
😞 I've created #80 to discuss |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.