Skip to content

Improvement Sandbox ENT`s#2109

Open
friztailo wants to merge 7 commits intoFacepunch:masterfrom
friztailo:ents
Open

Improvement Sandbox ENT`s#2109
friztailo wants to merge 7 commits intoFacepunch:masterfrom
friztailo:ents

Conversation

@friztailo
Copy link
Copy Markdown
Contributor

Improvements:

  • The result of ENT:BeingLookedAtByLocalPlayer() is now cached in the current frame to prevent unnecessary re-tracing.
  • Lights, lamps, emitters, thrusters have been optimized in terms of creating unnecessary garbage.
    Now they will not drop your fps so often due to garbage collection.

Comment thread garrysmod/gamemodes/sandbox/entities/entities/gmod_thruster.lua Outdated
@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Sep 3, 2024
Comment thread garrysmod/gamemodes/sandbox/entities/entities/gmod_hoverball.lua
Comment thread garrysmod/gamemodes/sandbox/entities/entities/base_gmodentity.lua Outdated
Comment thread garrysmod/gamemodes/sandbox/entities/entities/gmod_emitter.lua Outdated
Comment thread garrysmod/gamemodes/sandbox/entities/entities/gmod_lamp.lua Outdated
@neico
Copy link
Copy Markdown
Contributor

neico commented Nov 7, 2024

I've checked with the contributing file, and it's not stated there explicitly, but wasn't it generally agreed upon that things like operators shouldn't be changed from C-Style to lua style just for the sake of it?
I'm seeing quite a few ! to not changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement The pull request enhances current functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants