Add hook.ProtectedRun and hook.ProtectedCall functions#2175
Open
Srlion wants to merge 1 commit intoFacepunch:masterfrom
Open
Add hook.ProtectedRun and hook.ProtectedCall functions#2175Srlion wants to merge 1 commit intoFacepunch:masterfrom
Srlion wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Contributor
|
Would be very nice to avoid some random workshop script breaking servers when it causes a minor error in an initialization hook. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hook.ProtectedCall/ProtectedRunwill execute hooks without interruptions. If a hook returns a value or encounters an error, it will not halt the execution of the remaining hooks.These functions are particularly useful for hooks that do not expect a return value, such as Initialize hooks.
Many poorly designed addons in the workshop return values within critical hooks, making it difficult to track down what is preventing a hook from working correctly or causing issues.
Here is a simple list of hooks that could benefit from it:
GM:PreGamemodeLoaded
GM:OnGamemodeLoaded
GM:PostGamemodeLoaded
GM:Initialize
GM:OnEntityCreated
GM:EntityRemoved
GM:InitPostEntity