Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort favourite servers at the top of the server list #2214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DarthTealc
Copy link
Contributor

Favourited servers will now show at the top of the server list. They will still follow the sort options, but within that favourites grouping.
A small divider is shown between the last favourite server and the first non-favourite server to assist visually, however the servers are still all part of the same listing so there isn't an issue with multiple scrollbars or anything like that.

Works in Awesomium and CEF86.

image

@robotboy655
Copy link
Collaborator

robotboy655 commented Feb 16, 2025

Why do you think this is necessary? What's wrong with having them in the favorites tab?

What happens when you have more favorites there than fits on the screen vertically?

@DarthTealc DarthTealc changed the title Always show favourite servers at the top of the server list Sort favourite servers at the top of the server list Feb 17, 2025
@DarthTealc
Copy link
Contributor Author

What happens when you have more favorites there than fits on the screen vertically?

Sorry, I shouldn't have called it "always show favourites". They're not stuck there, they're not a separate list or position absolute. "Sort favourites" is a better description as they're just sorted to the top. So when you scroll they'll scroll off along with all the other servers.

gmod_ma6A5tcy1e.mp4

@@ -239,6 +239,11 @@ H1 small
background-color: #F1F6FF;
}

.serverlist .server.fav + .server:not(.fav)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where the border is applied, it's not a new list it's just a line between the last favourite and the first non-favourite. I could change this or remove this if it's making it look like the favourites are a different table

@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The pull request enhances current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants