Optimize widgets (but better)#2239
Merged
robotboy655 merged 5 commits intoFacepunch:masterfrom Oct 8, 2025
Merged
Conversation
bloodycop6385
suggested changes
Apr 3, 2025
robotboy655
requested changes
May 9, 2025
robotboy655
requested changes
Jul 31, 2025
Contributor
Author
|
There's a corresponding change in |
Collaborator
|
Do you not see the potential issues this can create with 3rd party addon content? |
Backwards compatibility with existing content, hide the internal widgets list table
robotboy655
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Based on (and supersedes) #915
Closes #2902
In addition to the changes made in the original PR, the following improvements have been made:
widgets.RenderMeis no longer necessary (its logic has been optimized and moved into the rendering hook directly) and has been stubbed out. I'm not sure if any addons that interact with this function even exist, so any suggestions on whether it should be kept functional, removed entirely, or kept stubbed out would be appreciatedThe widget system still won't be particularly performant, but it runs at least decently faster now, and manually removing the system entirely should no longer be necessary for a performance boost.