Skip to content

DProperty_Float SetMin/SetMax passthrough #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blobles-dev
Copy link
Contributor

I can't think of a good reason why these weren't added, you've got to do some panel child-hunting to locate it otherwise, thx

I can't think of a good reason why these weren't added, you've got to do some panel child-hunting to locate it otherwise
@blobles-dev blobles-dev changed the title SetMin/SetMax passthrough DProperty_Float SetMin/SetMax passthrough Mar 25, 2025
@blobles-dev
Copy link
Contributor Author

I realised the potential issues with NetworkVar/editable entities:

perhaps either:
add warning to wiki (this wont effect editable entity panels), you can edit the slider anyway by playing child-fu
or
ignore editable entity setmax/setmin calls

@robotboy655 robotboy655 added the Addition The pull request adds new functionality. label Apr 3, 2025
@robotboy655
Copy link
Collaborator

I am not quite sure what you mean by the second comment? Do you think this is a good idea to merge or no? Is your intention to use these in conjunction with NetworkVars, which I think already set the min/max for you?

@blobles-dev
Copy link
Contributor Author

blobles-dev commented Apr 9, 2025

I think we can disregard my previous stupor. I haven't used editable entities so I assumed they were manually created panels - which led me to think that if you set a value on a network var DProperty there would be mis-alignment. I think the only way to achieve this misalignment with editable entities if this pull request is merged would be through intentional fuckery so yeah by all means boss let's merge

Edit (Sober translation):
I think we can ignore my last comment. I haven't used editable entities panels and I assumed they were manually created, which could lead to misalignment after setting up the entities datatables with specific min/maxs and then calling SetMin/SetMax on the DProperty, I dont really think it's that big of a deal as you have to go out of you way to do some messing about but I wanted to flag it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Addition The pull request adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants