feat: add contract setters, apply loyalty discounts, allow channel to… - #510
Merged
fati-Onchain merged 1 commit intoJul 30, 2026
Conversation
…p-ups, pay out vouchers [Enhancement] No way to update payment_contract/escrow_contract/refund_contract addresses after initialize — a redeployed child contract can never be repointed without redeploying the coordinator Fixes Facil-Pay#486 [Enhancement] Loyalty point redemption computes a discount but never deducts it from the payment — customers who redeem points still pay full price Fixes Facil-Pay#490 [Enhancement] Payment channels cannot be topped up — a customer must close and reopen a new channel once the deposit is spent down Fixes Facil-Pay#491 [Enhancement] redeem_refund_voucher marks a voucher as redeemed but never transfers funds or applies credit to a payment Fixes Facil-Pay#493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…p-ups, pay out vouchers
[Enhancement] No way to update payment_contract/escrow_contract/refund_contract addresses after initialize — a redeployed child contract can never be repointed without redeploying the coordinator Fixes #486
[Enhancement] Loyalty point redemption computes a discount but never deducts it from the payment — customers who redeem points still pay full price Fixes #490
[Enhancement] Payment channels cannot be topped up — a customer must close and reopen a new channel once the deposit is spent down Fixes #491
[Enhancement] redeem_refund_voucher marks a voucher as redeemed but never transfers funds or applies credit to a payment Fixes #493
Summary
Test Plan
cargo test --workspace