upgrade facility definition #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejball
approved these changes
Oct 16, 2023
| @@ -13,7 +13,7 @@ | |||
| <PackageReference Include="Facility.CodeGen.CSharp" Version="2.14.5" /> | |||
| <PackageReference Include="Facility.CodeGen.JavaScript" Version="2.4.0" /> | |||
| <PackageReference Include="Facility.CodeGen.Markdown" Version="2.4.2" /> | |||
| <PackageReference Include="Facility.Definition" Version="2.7.1" /> | |||
| <PackageReference Include="Facility.Definition" Version="$(FacilityVersion)" /> | |||
There was a problem hiding this comment.
What's the advantage of using a property?
There was a problem hiding this comment.
I was just opting to keep this consistent with fls. @ddunkin had suggested this there FacilityApi/FacilityLanguageServer#8 (comment).
There was a problem hiding this comment.
IMHO a property is only valuable when the same version is used for multiple related packages.
There was a problem hiding this comment.
That makes sense. I don't have any opinion on it and I can remove the PropertyGroup if you think this is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the live editor was out of date and not recognizing the
externkeyword.