-
Notifications
You must be signed in to change notification settings - Fork 7
Add CurrentHashRate to PegnetMiner #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add CurrentHashRate to PegnetMiner #61
Conversation
This command allows for the collection of statistics at any time, instead of waiting until submitting results.
Add notification channels for the current hash rate and for submissions. This goroutine and these notification channels allow programs to provide users with current statistics.
|
With the |
|
I'll get to this today. thanks for the contribution |
|
@epineapple Is this PR complete? The new clients are always initialized with a nil. So the feature is always off. Is there something you need from me or want me to review before you continue? |
|
This PR is complete. The use of it is coming in a second PR, which changes Thanks! |
If `InitMiners` has not completed (because LXRHash is building the 1GB table file) and the `ReportHashRate` timer is triggered, the `SendCommand` call dereferences a null pointer. (It might be a good idea to add a check in `SendCommand`.) This change defers starting the `ReportHashRate` goroutine until the end of `InitMiners`.
|
I've found and fixed a crash pineapple-electric/prosper-pool@891ff3a. I'll add a console command to expose CurrentHashRate. I'd like to get some feedback on pegnet/LXRHash#69 and pegnet/LXRHash#70 before I submit the next PR. |
Add the "startfeed" and "stopfeed" commands. The feed will print a message when a share is submitted and print the current hash rate at regular intervals.
|
You should be able to test this function with the |
891ff3a fixed a crash by moving a goroutine. This change fixes that fix by putting the goroutine outside of the loop.
This command allows for the collection of statistics at any time, instead of waiting until submitting results.
This command is not currently used. The function that uses this command is coming in a different pull request.