DO-NOT-MERGE: debug #1514 #1515
Conversation
WalkthroughWalkthroughThe changes encompass a variety of modifications across several files. Key adjustments include enhancing log output in a test script, refining the destructor in a transport device class, improving header inclusions and type assertions, initializing class members, adding new methods for listing objects, and updating build configurations. Additionally, a new method was introduced to manage a non-owning Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant TestScript
participant LogFile
participant FairMQTransportDevice
participant FairModule
participant FairGeoInterface
participant FairGeoLoader
participant FairGeoSet
User->>TestScript: Run test-splitMQ.sh.in
TestScript->>LogFile: Display 100 lines for failed devices
FairMQTransportDevice->>FairMQTransportDevice: Destructor with logging and conditional method call
FairModule->>FairModule: Include adjustments and static assertions
FairGeoInterface->>FairGeoInterface: Initialize members, add ls method
FairGeoLoader->>FairGeoLoader: Add ls method
FairGeoSet->>FairGeoSet: Destructor handles non-owning TList
This diagram illustrates the primary interactions and changes introduced in this update, focusing on the new methods and adjustments in logging, destructors, and includes. Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ChristianTackeGSI
force-pushed
the
pr/debug_1514
branch
from
4b2da0c
to
b802e4a
Compare
ChristianTackeGSI
force-pushed
the
pr/debug_1514
branch
4 times, most recently
from
9f31cd6
to
cf312c2
Compare
FairGeoSet has non-owning references inside a TList to FairGeoNodes. When the dtor of FairGeoSet is called, those FairGeoNodes might already have been destroyed. Calling `Clear` with `"nodelete"` will just remove all the references without touching them.
ChristianTackeGSI
force-pushed
the
pr/debug_1514
branch
from
cf312c2
to
332e015
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| if (volumes && !volumes->IsOwner()) { | ||
| // destructing a TList that doesn't own its contents | ||
| // still touches the objects inside, even if they're | ||
| // already destroeyed |
There was a problem hiding this comment.
Correct typo in the comment.
- // already destroeyed
+ // already destroyedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| // already destroeyed | |
| // already destroyed |
See: #1514
Checklist:
Summary by CodeRabbit
New Features
lsmethod to list objects inFairGeoInterfaceandFairGeoLoader.Bug Fixes
test-splitMQ.sh.in.Chores
Improvements
FairGeoSetfor non-owningTListobjects.