Skip to content

Commit

Permalink
adding some basic GKE tests
Browse files Browse the repository at this point in the history
  • Loading branch information
robscott committed Mar 18, 2019
1 parent 62dffec commit f1180ce
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lookup/gke.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func getClusterInfo(c *clientcmdapi.Config, kubeContext string) *gkeClusterInfo

ci := gkeClusterInfo{}

if context.Cluster != "" {
if context != nil && context.Cluster != "" {
s := strings.Split(context.Cluster, "_")
if s[0] == "gke" {
ci.ClusterName = s[3]
Expand Down
41 changes: 41 additions & 0 deletions lookup/gke_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// Copyright 2018 ReactiveOps
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package lookup

import (
"testing"

"github.com/stretchr/testify/assert"

clientcmdapi "k8s.io/client-go/tools/clientcmd/api"
)

func TestGetClusterInfo(t *testing.T) {
config1 := clientcmdapi.Config{
Contexts: map[string]*clientcmdapi.Context{
"not-gke": {
Cluster: "helloworld",
},
"actual-gke": {
Cluster: "gke_reactiveopsio_us-central1-a_rbac-lookup-testing",
},
},
CurrentContext: "bar",
}

assert.Equal(t, getClusterInfo(&config1, "").ClusterName, "")
assert.Equal(t, getClusterInfo(&config1, "not-gke").ClusterName, "")
assert.Equal(t, getClusterInfo(&config1, "actual-gke").ClusterName, "rbac-lookup-testing")
}

0 comments on commit f1180ce

Please sign in to comment.