Upgrade AWS root volume to gp3 (it's cheaper) (#77)

* Upgrade AWS root volume type to gp3 (it's cheaper) * terraform fmt * Quotes
FairwindsOps · Jan 5, 2023 · 988bc6c · 988bc6c
1 parent 533a622
commit 988bc6c
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 6 deletions.
diff --git a/aws/README.md b/aws/README.md
@@ -242,6 +242,14 @@ Type: `string`
 
 Default: `"true"`
 
+#### root\_volume\_type
+
+Description: The root volume type for the bastion instance.
+
+Type: `string`
+
+Default: `"gp3"`
+
 #### ssh\_cidr\_blocks
 
 Description: A list of CIDRs allowed to SSH to the bastion. Override the module default by specifying an empty list, []

diff --git a/aws/auto-scaling.tf b/aws/auto-scaling.tf
@@ -22,8 +22,8 @@ resource "aws_autoscaling_group" "bastion" {
   dynamic "tag" {
     for_each = var.extra_asg_tags
     content {
-      key = tag.value["key"]
-      value = tag.value["value"]
+      key                 = tag.value["key"]
+      value               = tag.value["value"]
       propagate_at_launch = tag.value["propagate_at_launch"]
     }
   }

diff --git a/aws/inputs.tf b/aws/inputs.tf
@@ -113,7 +113,13 @@ variable "encrypt_root_volume" {
 }
 
 variable "extra_asg_tags" {
-  type = list
+  type        = list
   description = "Extra tags for the bastion autoscaling group"
-  default = []
+  default     = []
+}
+
+variable "root_volume_type" {
+  type        = string
+  description = "The root volume type for the bastion instance"
+  default     = "gp3"
 }
diff --git a/aws/launchconfig.tf b/aws/launchconfig.tf
@@ -35,10 +35,11 @@ resource "aws_launch_configuration" "bastion" {
   associate_public_ip_address = "true"
 
   user_data_base64 = base64gzip(data.template_file.bastion_user_data.rendered)
-  key_name = length(aws_key_pair.bastion) > 0 ? aws_key_pair.bastion[0].id : null
+  key_name         = length(aws_key_pair.bastion) > 0 ? aws_key_pair.bastion[0].id : null
 
   root_block_device {
-    encrypted = var.encrypt_root_volume
+    encrypted   = var.encrypt_root_volume
+    volume_type = var.root_volume_type
   }
 
   lifecycle {