Skip to content

fix(bulk_insert): align default --server-url and help text with bulk_update#61

Open
gkorland wants to merge 1 commit into
masterfrom
fix/server-url-default-alignment
Open

fix(bulk_insert): align default --server-url and help text with bulk_update#61
gkorland wants to merge 1 commit into
masterfrom
fix/server-url-default-alignment

Conversation

@gkorland

@gkorland gkorland commented Apr 26, 2026

Copy link
Copy Markdown

Summary

Both CLI entrypoints now use the same default for --server-url:

  • bulk_insert: falkor://127.0.0.1:6379 (aligned with bulk_update)
  • bulk_update: falkor://127.0.0.1:6379 (unchanged)

The help text on bulk_insert has also been updated from "Redis connection url" to "FalkorDB connection url" to match bulk_update.

This builds on PR #68 which removed the redis.from_url() call from bulk_insert; that call previously rejected the falkor:// scheme.

Changes

  • falkordb_bulk_loader/bulk_insert.py: change --server-url default to falkor://127.0.0.1:6379 and update help text

Testing

Existing tests pass. No behaviour change for users who specify --server-url explicitly.

Memory / Performance Impact

N/A.

Related Issues

From the comprehensive code-review report (BUG-17).

@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@gkorland has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes and 50 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 495fff49-fe89-4e86-8ee0-ea531b520d3b

📥 Commits

Reviewing files that changed from the base of the PR and between 3954856 and f4b67b1.

📒 Files selected for processing (1)
  • falkordb_bulk_loader/bulk_insert.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/server-url-default-alignment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 41 minutes and 50 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.50%. Comparing base (3954856) to head (f4b67b1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files           9        9           
  Lines         610      610           
=======================================
  Hits          546      546           
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gkorland
gkorland marked this pull request as ready for review April 26, 2026 17:21
@gkorland
gkorland requested a review from Copilot April 26, 2026 17:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the default FalkorDB connection URL across the two CLI entrypoints so users get consistent behavior when they don’t pass --server-url.

Changes:

  • Updates bulk_update’s --server-url default to redis://127.0.0.1:6379 to match bulk_insert.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gkorland

Copy link
Copy Markdown
Author

Copilot Code Review

No significant issues found.

@gkorland
gkorland force-pushed the fix/server-url-default-alignment branch from e71d330 to e7b7c05 Compare April 29, 2026 06:37
@gkorland gkorland changed the title fix(bulk_update): align default --server-url with bulk_insert fix(bulk_insert): align default --server-url and help text with bulk_update Apr 29, 2026
…update

Both CLIs now use falkor://127.0.0.1:6379 as the default --server-url
and the consistent help text 'FalkorDB connection url'.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gkorland
gkorland force-pushed the fix/server-url-default-alignment branch from e7b7c05 to f4b67b1 Compare April 29, 2026 06:39
@gkorland

Copy link
Copy Markdown
Author

Agent Review Summary

Problem Found

The PR branch had accumulated confusing commits that introduced a CI-breaking bug:

  • Commit e71d330 changed bulk_insert.py's default --server-url to falkor://, but the branch had not yet rebased past PR fix(bulk_insert): drop redundant redis_con; reuse client.connection #68 — which removed the redis.from_url()\ call that explicitly rejects non-redis://` schemes.
  • Result: ValueError: Redis URL must specify one of the following schemes (redis://, rediss://, unix://) on every test invocation.

Actions Taken

  1. Rebased the branch onto current master (picking up PR fix(bulk_insert): drop redundant redis_con; reuse client.connection #68's removal of the redundant redis.from_url() call).
  2. Squashed three confusing commits into one clean conventional commit.
  3. Fixed black formatting — expanded the single-line @click.option call to match the project's black-enforced style.
  4. Updated PR title and description to accurately reflect the single-line net change.

Final Change (vs master)

-    "--server-url", "-u", default="redis://127.0.0.1:6379", help="Redis connection url"
+    "--server-url",
+    "-u",
+    default="falkor://127.0.0.1:6379",
+    help="FalkorDB connection url",

Both bulk_insert and bulk_update now default to falkor://127.0.0.1:6379 with consistent help text.

CI Status

✅ All 9 checks pass (linting, Python 3.10, Python 3.11, CodeQL, Codecov).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants