Skip standalone test-fixture generation when embedded#32
Conversation
build.rs runs scripts/generate_test_certificates.sh in debug builds to set up TLS certs for the crate's own integration tests. That script walks up the tree looking for a directory literally named 'valkey-ldap' and loops forever when the crate is vendored as a submodule under a different name (e.g. modules/ldap), hanging the build. The fixtures are never used when the crate is embedded into a host module, so skip them whenever the 'embed' feature is enabled.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build script now skips debug-only fixture generation and copying when the crate is built with the ChangesEmbed-aware build script gating
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
build.rs runs scripts/generate_test_certificates.sh in debug builds to set up TLS certs for the crate's own integration tests. That script walks up the tree looking for a directory literally named 'valkey-ldap' and loops forever when the crate is vendored as a submodule under a different name (e.g. modules/ldap), hanging the build. The fixtures are never used when the crate is embedded into a host module, so skip them whenever the 'embed' feature is enabled.
Summary by CodeRabbit