Skip to content

Add C-callable entry point for LDAP INFO section handling#33

Merged
dudizimber merged 4 commits into
mainfrom
embed-ldap-config-prefix
Jul 7, 2026
Merged

Add C-callable entry point for LDAP INFO section handling#33
dudizimber merged 4 commits into
mainfrom
embed-ldap-config-prefix

Conversation

@dudizimber

Copy link
Copy Markdown

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@dudizimber, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2f6363f6-9c19-4d7e-9cea-00e20715d8ce

📥 Commits

Reviewing files that changed from the base of the PR and between aec7040 and 8d502ca.

📒 Files selected for processing (1)
  • src/commands.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch embed-ldap-config-prefix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a C-callable shim so that when valkey-ldap is embedded into a host C module (which owns the single Redis/Valkey INFO callback), the host can still invoke this crate’s collected INFO section handlers to emit LDAP-related INFO sections.

Changes:

  • Introduces an #[cfg(feature = "embed")] exported extern "C" function (LDAP_AddInfo) to bridge host INFO callbacks to valkey_module::basic_info_command_handler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/commands.rs Outdated
Comment thread src/commands.rs Outdated
dudizimber and others added 2 commits July 7, 2026 14:49
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Dudi <16744955+dudizimber@users.noreply.github.com>
@dudizimber
dudizimber merged commit 04512ff into main Jul 7, 2026
8 checks passed
@dudizimber
dudizimber deleted the embed-ldap-config-prefix branch July 7, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants