Fix continuation-related exploits and bump* stack limit #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… escaped iota size in stack limit
vgskye
force-pushed
the
no-fun-allowed
branch
from
35d2f46 to
6c5798b
Compare
|
I kind of like using Iris to smuggle truenames as an idea because it's so clever, but I'm not sure if it's bad or good for gameplay ... what do you all think? |
|
converting to draft because this needs performance regression testing |
| size += notDone.component1().size(); | ||
| continuation = notDone.component2(); | ||
| } | ||
| return Math.min(this.getContinuation().size(), 1); |
There was a problem hiding this comment.
this should be Math.max, as discussed on Discord - min results in the value only being 0 or 1, max results in the value being >=1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps stack size limit to 8k, but includes extra iotas stored in current CastingImage in the tally(escaped iotas and continuations).
Also fixes iris truename smuggling by properly implementing subIotas.