Skip to content

Conversation

miyucomics
Copy link
Contributor

I can think of at least a few cases in addons where a person would want to perform their own search of what a casting environment has to offer. Features in base generally shouldn't be done just for addons but I don't see why these very useful methods should be protected and it's currently impossible to access them with usual techniques like invokers because one of the parameters is also a protected enum. Access wideners also don't work because those exclusively only work for base Minecraft classes, not other mods.

Copy link
Member

@vgskye vgskye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it's probably possible to use ugly reflection to use these methods, so it's not completely impossible, but yeah LGTM

@object-Object
Copy link
Member

hmm, should we count this as a breaking change? it seems like it won't affect existing mod builds, but I think any addon that implements these methods would get a compilation error after this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Backlog

Development

Successfully merging this pull request may close these issues.

3 participants