Skip to content

Refactor/credit charge animation #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
two678 merged 5 commits into from
Apr 28, 2025
Merged

Refactor/credit charge animation #155

two678 merged 5 commits into from
Apr 28, 2025

Conversation

@ddumini
Copy link
Collaborator

@ddumini ddumini commented Apr 28, 2025 •
edited
Loading

πŸ“ Summary

초기 카운트 이슈 ν•΄κ²° 및 μžμž˜ν•œ μˆ˜μ •
Resolves: #154

πŸ”§ Changes

  • count μ• λ‹ˆλ©”μ΄μ…˜μ΄ λ„ˆλ¬΄ 해결이 μ•ˆλΌμ„œ μ €λ²ˆμ— λŒ€κ°• ν•˜κ³  였늘 λ‹€μ‹œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
  • 쑰건 μΆ”κ°€ν•˜κ³  μ΄ˆκΈ°κ°’μ„ μ•„μ–˜ 0으둜 λ³€κ²½ν•΄μ„œ ν•΄κ²°ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • 헀더 μœ„λ‘œ blur λ‚˜μ˜€κ²Œ 처리..
  • ν–ˆλ”λ‹ˆ 컨텐츠 μ˜μ—­μ„ κ°€λ € 선택이 μ•ˆλ  λ•Œκ°€ μžˆμ–΄ μ‚¬μ΄μ¦ˆλ₯Ό μ€„μ˜€μŠ΅λ‹ˆλ‹€.
  • μƒμ„ΈνŽ˜μ΄μ§€ donationAPI μ„œμ—°λ‹˜μ΄ λ§Œλ“œμ‹  useDonation ν›… μ‚¬μš©μœΌλ‘œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
  • λ‚΄μš©μ— λΌλŠ” / μ΄λΌλŠ” 쑰사 μ‚¬μš©μ΄ μ–΄μƒ‰ν•˜μ—¬ utilν•¨μˆ˜μ— μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • μ§€ν˜„λ‹˜μ΄ λ§Œλ“œμ‹  쀑볡 클릭 ν›… μ‚¬μš© λΆ€λΆ„ 더블클릭에 μ—¬μ „νžˆ λ°˜μ‘ν•˜μ—¬ μ•½κ°„ μˆ˜μ •ν–ˆμœΌλ‚˜
  • λ¦¬νŒ©ν„°λ§μ΄ ν•„μš”ν•΄λ³΄μ΄μ‹œλ©΄ 더 μˆ˜μ •ν•˜μ…”λ„ λ©λ‹ˆλ‹€!

βœ… Checklist

  • μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ 사항을 ν…ŒμŠ€νŠΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ„€λͺ…을 μΆ©λΆ„νžˆ μž‘μ„±ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ˜¬λ°”λ₯Έ λΈŒλžœμΉ˜μ— PR을 λ³΄λƒˆμŠ΅λ‹ˆλ‹€.
  • 🀞 λ¦¬λ·°μ–΄μ˜ λ§ˆμŒμ„ μ‚¬λ‘œμž‘μ•˜μŠ΅λ‹ˆλ‹€.

πŸ“š Additional

  • μ•„λ§ˆλ„ 이 PR은 λ‹€ν¬ν˜ΈμŠ€μΌμ§€λ„... 🎩✨
  • λ°œν‘œ 전에 μˆ˜μ •ν•  사항듀이 더 생기면 μΆ”κ°€λ‘œ μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€.

🚨 "λͺ¨λ“  PRμ—λŠ” 컀피가 ν•„μš”ν•˜λ‹€!" β˜•

ddumini added 5 commits April 28, 2025 10:20
@ddumini
♻️ Refactor: 초기 μΉ΄μš΄νŠΈμ—… λͺ¨μ…˜ μž¬μˆ˜μ •
980571a 
μ΄ˆκΈ°κ°’ μˆ˜μ • 및 쑰건 μΆ”κ°€λ‘œ 이슈 ν•΄κ²°
@ddumini
πŸ’„ Fix: 리슀트 blurμ˜μ—­ 헀더 μœ„λ‘œ λ…ΈμΆœ
b26d511 
blur μš”μ†Œ z-indexλ₯Ό header보닀 λ†’κ²Œ μˆ˜μ •
@ddumini
πŸ’„ Fix: blur에 겹쳐 선택 μ•ˆλ˜λŠ” 이슈 ν•΄κ²°
c60d5fa 
blurμ˜μ—­ μ€„μž„
@ddumini
♻️ Fix: postPosition utilν•¨μˆ˜μ— 쑰사 μΆ”κ°€
4b4c7b1 
μ΄λΌλŠ”, λΌλŠ” μΆ”κ°€
@ddumini
♻️ Fix: 후원을 κΈ°λ‹€λ¦¬λŠ” 쑰곡 상세 νŽ˜μ΄μ§€ useDonation ν›… 적용
7932115 
상세 νŽ˜μ΄μ§€ ν›… 적용 및 쀑볡 클릭 처리 μˆ˜μ •
@ddumini ddumini self-assigned this Apr 28, 2025
@ddumini ddumini added this to the UI Polish milestone Apr 28, 2025
@Seon-K
Copy link
Collaborator

Seon-K commented Apr 28, 2025

λ§ˆμ§€λ§‰? λ¦¬νŒ©ν† λ§λ„..! λ„ˆλ¬΄ μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!! πŸ‘ πŸ‘

Seon-K
Seon-K approved these changes Apr 28, 2025
View reviewed changes
src/pages/DonationDetail/components/DonationDetailInfo.jsx
onClick={handleDonate}
>
{isSubmitting ? "μΆ©μ „ 쀑..." : "μΆ©μ „ν•˜κΈ°"}
{isSubmitting ? "후원 처리 쀑..." : "ν›„μ›ν•˜κΈ°"}
Copy link
Collaborator

@Seon-K Seon-K Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ™€μš° λ””ν…ŒμΌ ...!

src/utils/postPosition.js
이가: hasBatchim ? "이" : "κ°€",
을λ₯Ό: hasBatchim ? "을" : "λ₯Ό",
으둜: hasBatchim ? "으둜" : "둜",
λΌλŠ”μ΄λΌλŠ”: hasBatchim ? "μ΄λΌλŠ”" : "λΌλŠ”",
Copy link
Collaborator

@Seon-K Seon-K Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

옷! hasλ°›μ·Έ!

@two678
Copy link
Contributor

two678 commented Apr 28, 2025

더블클릭이 아직도 μžˆμ—ˆκ΅°μš”.... πŸ˜… μˆ˜μ •ν•΄μ£Όμ…”μ„œ κ°μ‚¬ν•΄μš”!

@two678 two678 merged commit 24f465a into develop Apr 28, 2025
0 of 2 checks passed
@ddumini
Copy link
Collaborator Author

ddumini commented Apr 28, 2025

더블클릭이 아직도 μžˆμ—ˆκ΅°μš”.... πŸ˜… μˆ˜μ •ν•΄μ£Όμ…”μ„œ κ°μ‚¬ν•΄μš”!

λ§Œλ“€μ–΄μ£Όμ‹  ν›…μ΄λž‘ ν•¨μˆ˜ κ³ λŒ€λ‘œ μ‚¬μš©ν–ˆμŠ΅λ‹ˆλ‹Ήγ…Žγ…Ž

@ddumini ddumini deleted the refactor/credit-charge-animation branch April 28, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Seon-K Seon-K Seon-K approved these changes

@two678 two678 Awaiting requested review from two678

@TopiaYu TopiaYu Awaiting requested review from TopiaYu

@Taeil08 Taeil08 Awaiting requested review from Taeil08

Assignees

@ddumini ddumini

Labels

πŸ”¨ λ¦¬νŒ©ν† λ§

Projects

None yet

Milestone

UI Polish

Development

Successfully merging this pull request may close these issues.

[ν¬λ ˆλ”§ μΆ©μ „ν•˜κΈ° λ¦¬νŽ™ν„°λ§ 및 λ‚˜λ¨Έμ§€ μžμž˜ν•œ μˆ˜μ •]

4 participants

@ddumini @Seon-K @two678