Skip to content

Conversation

@ddumini
Copy link
Collaborator

@ddumini ddumini commented Apr 28, 2025

๐Ÿ“ Summary

๋ชจ๋“  ํŽ˜์ด์ง€์— ์Šค๋ฌด์Šค ์Šคํฌ๋กค ์ ์šฉ
Resolves: #159

๐Ÿ”ง Changes

  • ์Šค๋ฌด์Šค ์Šคํฌ๋กค ์ ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค. ๊ฐœ์ทจ์กด์ค‘ ๋บ€๊ฒŒ ๋‚ซ๋‹ค๊ณ  ์ƒ๊ฐํ•˜์‹œ๋ฉด ๊ธฐ์กด์ฒ˜๋Ÿผ ๋žœ๋”ฉ์—๋งŒ ์ ์šฉํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.
  • ์Šคํฌ๋กค ํšจ๊ณผ๊ฐ€ ๋ชจ๋‹ฌ์— ์˜ํ–ฅ์ด ์žˆ์–ด data-lenis... ๋ผ๋Š” ์†์„ฑ์˜ div๋กœ ๊ฐ์‹ธ์ฃผ์–ด ์ด์Šˆ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๋žœ๋”ฉ ํŽ˜์ด์ง€ ๋ชจ๋ฐ”์ผ ๋””๋ฐ”์ด์Šค์—์„œ ๋ธŒ๋ผ์šฐ์ € ์ฃผ์†Œ์ฐฝ, ํ•˜๋‹จ ๋ฐ” ๋•Œ๋ฌธ์— 100vh๊ฐ€ warigariํ•œ ์ด์Šˆ๋กœ ;;
  • ๊ธฐ์กด ์• ๋‹ˆ๋ฉ”์ด์…˜์„ ๋นผ๊ณ  768๋ถ€ํ„ฐ ๋ฐ”๊ฟ”๋ณด์•˜์Šต๋‹ˆ๋‹ค.

โœ… Checklist

  • ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ํ…Œ์ŠคํŠธํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ์„ค๋ช…์„ ์ถฉ๋ถ„ํžˆ ์ž‘์„ฑํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ์˜ฌ๋ฐ”๋ฅธ ๋ธŒ๋žœ์น˜์— PR์„ ๋ณด๋ƒˆ์Šต๋‹ˆ๋‹ค.
  • ๐Ÿคž ๋ฆฌ๋ทฐ์–ด์˜ ๋งˆ์Œ์„ ์‚ฌ๋กœ์žก์•˜์Šต๋‹ˆ๋‹ค.

๐Ÿ“š Additional

  • ์•„๋งˆ๋„ ์ด PR์€ ๋‹คํฌํ˜ธ์Šค์ผ์ง€๋„... ๐ŸŽฉโœจ
  • ์—๋Ÿฌ ์ฒดํฌ ํ–ˆ์ง€๋งŒ ์ถ”ํ›„ ๋ฐœ๊ฒฌ์‹œ ๋‹ค์‹œ ์ž‘์—… ํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค~

๐Ÿšจ "๋ชจ๋“  PR์—๋Š” ์ปคํ”ผ๊ฐ€ ํ•„์š”ํ•˜๋‹ค!" โ˜•

ddumini added 3 commits April 28, 2025 17:07
smooth scroll ๋ชจ๋“  ํŽ˜์ด์ง€์— ์ ์šฉ
smooth scroll ๋ชจ๋‹ฌ ์˜คํ”ˆ์‹œdata-lenis-prevent ์†์„ฑ ์ถ”๊ฐ€ํ•˜์—ฌ ๋ง‰๊ธฐ  ์ฒ˜๋ฆฌ
๋ชจ๋ฐ”์ผ ๋””๋ฐ”์ด์Šค๋ณ„ ์ƒ์ดํ•œ ํƒญ๊ณผ ์ฃผ์†Œ์ฐฝ์— ๋Œ€์‘ํ•ด ์• ๋‹ˆ๋ฉ”์ด์…˜ ์ˆ˜์ •
@two678
Copy link
Contributor

two678 commented Apr 28, 2025

์ˆ˜๋ฏผ๋‹˜ ์ด๊ฑฐ pr refactor/all-smooth-scroll -> develop ์œผ๋กœ ๊ฐ€๊ฒŒ ์„ค์ •ํ•ด์ฃผ์„ธ์šฉ~

@ddumini ddumini changed the base branch from main to develop April 28, 2025 10:54
@ddumini ddumini self-assigned this Apr 28, 2025
@ddumini ddumini added this to the UI Polish milestone Apr 28, 2025
Copy link
Contributor

@two678 two678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค! ๋จธ์ง€ํ•œ๋‹ค์Œ์— ์–ด๋–ค์ง€ ํ™•์ธํ•ด๋ณผ๊ฒŒ์šฉ!

const lenisRef = useRef(null);

// Lenis ์Šคํฌ๋กค ์ดˆ๊ธฐํ™”
useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜คํ™ ๋‚˜์ค‘์— ํŒ๋‹ค๋งˆ์ผ“ ํ•  ๋•Œ๋„ ํ•œ๋ฒˆ ์ ์šฉ์‹œ์ผœ๋ณด๊ณ ์‹ถ๋„ค์šฉ๐Ÿ˜Š๐Ÿ˜Š

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์Šต๋‹ˆ๋‹ท~ใ…Žใ…Ž

@two678 two678 merged commit 6355299 into develop Apr 28, 2025
1 check passed
@ddumini ddumini deleted the refactor/all-smooth-scroll branch April 28, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[smooth scroll ๋ชจ๋“  ํŽ˜์ด์ง€์— ์ ์šฉ]

3 participants