Skip to content

Fix/donation detail credit limit error #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
two678 merged 3 commits into from
Apr 29, 2025
Merged

Fix/donation detail credit limit error #170

two678 merged 3 commits into from
Apr 29, 2025

Conversation

@ddumini
Copy link
Collaborator

@ddumini ddumini commented Apr 29, 2025 •
edited
Loading

πŸ“ Summary

Resolves: #164

πŸ”§ Changes

  • ν˜„μž¬ ν¬λ ˆλ”§ μ΄ˆκ³Όμ‹œ 메세지 쀑볡 μ•ˆλ˜λ©΄μ„œ λ²„νŠΌ ν™œμ„±ν™”
  • λͺ©ν‘œκΈˆμ•‘ μ΄ˆκ³Όμ‹œ μ—λŸ¬ μ²˜λ¦¬λŠ” 좔후에 ν•˜κ² μŠ΅λ‹ˆλ‹€.

βœ… Checklist

  • μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • λ³€κ²½ 사항을 ν…ŒμŠ€νŠΈν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ„€λͺ…을 μΆ©λΆ„νžˆ μž‘μ„±ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ˜¬λ°”λ₯Έ λΈŒλžœμΉ˜μ— PR을 λ³΄λƒˆμŠ΅λ‹ˆλ‹€.
  • 🀞 λ¦¬λ·°μ–΄μ˜ λ§ˆμŒμ„ μ‚¬λ‘œμž‘μ•˜μŠ΅λ‹ˆλ‹€.

πŸš€ Test Plan

  • ν‚€λ³΄λ“œλ‘œ 인풋에 초과 κΈˆμ•‘ μž…λ ₯ ν˜Ήμ€ κΈˆμ•‘ μΆ”κ°€ λ²„νŠΌ ν΄λ¦­ν•˜μ—¬ 초과되게

πŸ“š Additional

  • μ•„λ§ˆλ„ 이 PR은 λ‹€ν¬ν˜ΈμŠ€μΌμ§€λ„... 🎩✨
  • 쉽지 μ•Šλ„€μš”.. 점점 κΈΈμ–΄μ§€λŠ” μ½”λ“œ..γ… γ… 

🚨 "λͺ¨λ“  PRμ—λŠ” 컀피가 ν•„μš”ν•˜λ‹€!" β˜•

ddumini added 3 commits April 29, 2025 11:26
@ddumini
πŸ› Fix: 후원 상세 μ—λŸ¬λ©”μ„Έμ§€ 쀑볡 ν•΄κ²° 및 λ²„νŠΌ disabled μƒνƒœ μ‘°μ •
c91f2f2 
후원 상세 μ—λŸ¬λ©”μ„Έμ§€ 쑰건 μΆ”κ°€ν•˜μ—¬ 쀑볡 ν•΄κ²° 및 κ°’ λ³€κ²½λœ ν›„ λ²„νŠΌ disabled μƒνƒœ μ‘°μ •
@ddumini
πŸ› Fix: λͺ©ν‘œ κΈˆμ•‘ μ΄ˆκ³Όμ‹œ μ—λŸ¬λ©”μ„Έμ§€ 및 λ²„νŠΌ λΉ„ν™œμ„±ν™”
f4390a3 
λͺ©ν‘œκΈˆμ•‘ μ΄ˆκ³Όμ‹œ μ—λŸ¬λ©”μ„Έμ§€ 및 λ²„νŠΌ λΉ„ν™œμ„±ν™” μ™„λ£Œ
@ddumini
✨ Fix: ν˜„μ œ ν¬λ ˆλ”§ 초과 κΉŒμ§€λ§Œ κ΅¬ν˜„ / λͺ©ν‘œ κΈˆμ•‘ 초과 μΆ”ν›„ κ΅¬ν˜„
222da73 
λͺ©ν‘œ κΈˆμ•‘ 초과 μ—λŸ¬μ²˜λ¦¬ μΆ”ν›„ κ΅¬ν˜„ μ˜ˆμ •
@ddumini ddumini changed the base branch from main to develop April 29, 2025 05:12
two678
two678 approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@two678 two678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜κ³ ν•˜μ…¨μ–΄μš”~~ 후원μͺ½μ΄ 생각보닀 μ‹ κ²½μ“Έκ²Œ 더 λ§Žλ„€μš”..γ… 

@two678 two678 merged commit 1ab87ad into develop Apr 29, 2025
1 check passed
@Seon-K
Copy link
Collaborator

Seon-K commented Apr 29, 2025

λ„ˆλ¬΄ μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ !! γ… γ…  πŸ‘ πŸ‘
덕뢄에 더 완성도 높은 ν”„λ‘œμ νŠΈκ°€ λ˜μ–΄κ°€κ³  μžˆλŠ” 것 κ°™μ•„μš” !

@ddumini ddumini deleted the fix/donation-detail-credit-limit-error branch April 29, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@two678 two678 two678 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddumini @Seon-K @two678