Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick «Some Language Fixes» #395

Merged

Conversation

Mnemotechnician
Copy link
Collaborator

Description

Cherry-picks Simple-Station/Einstein-Engines#1223

Because the upstream merge is a whole week away (or whenever I get the motivation to debug the issues with it)

Original body:

Click to expand

  1. Adds languages to... penguins, cockroaches, snakes, mmis, pdas, mail packages. Positronic brains now only speak/understand the borg language.
  2. Adds an explicitly defined universal language to revenants and wisps
  3. Makes polymorphs copy over a list of components defined in the polymorph proto, thus copying languages and grammar of the original entity to its polymorphed version.

image

image

image

image

Changelog

🆑

  • tweak: Added languages to certain entities that lacked them, including MMIs and positronic brains.
  • add: Polymorphing into another entity now preserves your languages and grammar.

Changelog

🆑

  • tweak: Cherry-picked some changes to languages made upstream.

# Description
1. Adds languages to... penguins, cockroaches, snakes, mmis, pdas, mail
packages. Positronic brains now only speak/understand the borg language.
2. Adds an explicitly defined universal language to revenants and wisps
3. Makes polymorphs copy over a list of components defined in the
polymorph proto, thus copying languages and grammar of the original
entity to its polymorphed version.

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/111c3f91-f077-431f-bcd9-f60fa7a1ba26)


![image](https://github.com/user-attachments/assets/80f939d3-b615-4235-a511-82238758788e)


![image](https://github.com/user-attachments/assets/dce99b55-c8b1-4cbe-8769-b82151b3d404)


![image](https://github.com/user-attachments/assets/6b9b962d-c73c-42b9-b240-aa07601de879)



</p>
</details>

# Changelog
:cl:
- tweak: Added languages to certain entities that lacked them, including
MMIs and positronic brains.
- add: Polymorphing into another entity now preserves your languages and
grammar.
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: YML Changes any yml files labels Dec 5, 2024
@Floof-Station-Bot Floof-Station-Bot changed the title Cherry-pick «Some Language Fixes» Cherry-Pick «Some Language Fixes» Dec 5, 2024
@FoxxoTrystan FoxxoTrystan merged commit 6e825b8 into Fansana:master Dec 7, 2024
17 checks passed
Floof-Station-Bot added a commit that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants