Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gymnasium==1.0 support #211

Merged
merged 8 commits into from
Feb 17, 2024
Merged

gymnasium==1.0 support #211

merged 8 commits into from
Feb 17, 2024

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Feb 14, 2024

Description

  • Updates import to work without the removed plugin system (and updates the DOC)
  • pin gymnasium==1.0.0a1
  • update tests to not use the removed env.get_attr()
  • fix bounds check string Fix mujoco_rendering.py Gymnasium#634
  • relax MuJuCo version requirements
  • added MazeEnv.model and MazeEnv.data properties (useful for testing)

Type of change

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review February 14, 2024 12:05
@Kallinteris-Andreas
Copy link
Collaborator Author

Kallinteris-Andreas commented Feb 14, 2024

Only MaMuJoCo-v0 environments tests are failing, requesting an approval regardless since this will be replaced with MaMuJoCo-v1 with the other PR
@rodrigodelazcano

@rodrigodelazcano rodrigodelazcano merged commit 12a336a into main Feb 17, 2024
1 of 9 checks passed
Kallinteris-Andreas added a commit to Kallinteris-Andreas/Gymnasium-Robotics-Kalli that referenced this pull request Feb 17, 2024
@Kallinteris-Andreas Kallinteris-Andreas deleted the Kallinteris-Andreas-patch-1 branch October 1, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants