Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_mujoco_reset_state #928

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Feb 16, 2024

Description

This was added mainly to address Gymnasium-Robotics's Farama-Foundation/Gymnasium-Robotics#207 Farama-Foundation/Gymnasium-Robotics#208, but it can also be used here and in metaworld?

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review February 16, 2024 10:12
@Kallinteris-Andreas
Copy link
Collaborator Author

Also, i forgot to add, that that fails for all RobotEnv based environment (and RobotPyEnv but we do not care about those), which is the reason this is added

FAILED test.py::test_reproducibility[FetchSlide-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[FetchPickAndPlace-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[FetchReach-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[FetchPush-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[HandReach-v1] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[FetchSlideDense-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[FetchPickAndPlaceDense-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[FetchReachDense-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[FetchPushDense-v2] - AssertionError: reset is not deterministic
FAILED test.py::test_reproducibility[HandReachDense-v1] - AssertionError: reset is not deterministic

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit ceb97f2 into main Feb 19, 2024
16 checks passed
@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the Kallinteris-Andreas-patch-11 branch February 19, 2024 22:08
traversaro added a commit to traversaro/Gymnasium that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants