Skip to content

Fix Jackson 3 regression for @JsonIdentityInfo #5238 #5299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix Jackson 3 regression for @JsonIdentityInfo #5238 #5299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
512711b
Fix 5238
JooHyukKim Sep 6, 2025
bbb236b
Clean up change
JooHyukKim Sep 6, 2025
1fa9811
Move test out
JooHyukKim Sep 6, 2025
904439e
Merge branch '3.x' into 5262
cowtowncoder Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/tools/jackson/databind/introspect/POJOPropertiesCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,12 @@ protected void _renameProperties(Map<String, POJOPropertyBuilder> props)
// simple renaming? Just do it
if (l.size() == 1) {
PropertyName n = l.iterator().next();
renamed.add(prop.withName(n));
if (getObjectIdInfo() != null) {
renamed.add(prop);
} else {
renamed.add(prop.withName(n));
}
Comment on lines +1503 to +1507
Copy link
Member Author

@JooHyukKim JooHyukKim Sep 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out was serializing id as prefixId (from creator).
So I thought... if objectId, let's not rename?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmh. Actually, I think this test is invalid! Renaming should be done, as described.

And would occur in 2.x if ParameterNamesModule was registered.

Sorry for wasting you time here @JooHyukKim :-(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue, but I am still concerened there might be issue because the serialization output changed from "id" to "prefixId" 🤔
Or could that also be affected by ALLOW_FINAL_FIELDS_AS_GETTERS?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difference is, I think, that 2.x does not get implicit names from constructor parameters (without ParameterNamesModule); 3.x does. So renaming works as -- I think -- it actually should, in 3.x (and in 2.x if PNM was registered).

Why @JsonProperty("prefixId") was added I do not know: seems like a mistake.


continue;
}
// but this may be problematic...
Expand Down
4 changes: 1 addition & 3 deletions ...s/tofix/JsonIdentityOnRecord5238Test.java → ...records/JsonIdentityOnRecord5238Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tools.jackson.databind.records.tofix;
package tools.jackson.databind.records;

import java.util.List;

Expand All @@ -8,7 +8,6 @@

import tools.jackson.databind.ObjectMapper;
import tools.jackson.databind.testutil.DatabindTestUtil;
import tools.jackson.databind.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand Down Expand Up @@ -51,7 +50,6 @@ public ThingPojo(@JsonProperty("prefixId") int id, @JsonProperty("name") String
private final ObjectMapper MAPPER = newJsonMapper();

// [databind#5262]: Regression in 3.0?
@JacksonTestFailureExpected
@Test
void testIdentityWithPojo() throws Exception {
ThingPojo t1 = new ThingPojo(1, "a");
Expand Down
Loading