Skip to content

Fix #628 for 3.1 #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2025
+82 −14
Merged

Fix #628 for 3.1 #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions avro/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,21 @@ abstractions.
</properties>

<dependencies>
<!-- Core deps from parent -->
<!-- Depend on Jackson core components -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- Also on Apache Avro codec for some encoding/decoding -->
<dependency>
<groupId>org.apache.avro</groupId>
<artifactId>avro</artifactId>
Expand All @@ -57,7 +70,7 @@ abstractions.
</dependency>

<!-- 14-Jan-2025, joohyukkim: [JSTEP-10] Most tests have been migrated to
JUnit5, but except `avro` modules `/interop` tests
JUnit5, except `avro` modules `/interop` tests
-->
<dependency>
<groupId>junit</groupId>
Expand Down
16 changes: 16 additions & 0 deletions cbor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,22 @@ encoded data using Jackson abstractions (streaming API, data binding, tree model
</properties>

<dependencies>
<!-- We depend on Jackson core components; annotations optionally/for tests -->
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- for testing we need annotations -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<scope>provided</scope>
</dependency>
</dependencies>

<build>
Expand Down
14 changes: 14 additions & 0 deletions ion/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,20 @@ tree model)
</properties>

<dependencies>
<!-- Depend on Jackson core components -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- actual decoding by core streaming Ion lib -->
<dependency>
<groupId>com.amazon.ion</groupId>
Expand Down
13 changes: 1 addition & 12 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,7 @@

<dependencies>
<!-- all dataformats extend core and databind, annotations; include here -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
<!-- 01-Nov-2025, tatu: [dataformats-binary#628] No longer -->

<!-- 11-Jan-2025, joohyukkim: For JSTEP-10, migrate to JUnit5 -->
<dependency>
Expand Down
17 changes: 17 additions & 0 deletions protobuf/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,23 @@ abstractions.
</properties>

<dependencies>
<!-- We depend on Jackson core components; annotations optionally/for tests -->
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- for testing we need annotations -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<scope>provided</scope>
</dependency>

<!-- uses protostuff libs for parsing, generation -->
<dependency>
<groupId>com.squareup</groupId>
Expand Down
3 changes: 3 additions & 0 deletions release-notes/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ implementations)
(requested by Andy W)
#623: (ion) Upgrade `ion-java` dep to 1.11.11 (from 1.11.10)
(requested by @Shaurya0108)
#628: (avro, cbor, ion, protobuf, smile) Uncommon parent pom dependency
configuration in Jackson 2.20/3.0
(reported by Josh C)
#629: (ion) Unnecessary `IOException` in `IonObjectMapper` method signatures
(fix contributed by Michael L)

Expand Down
16 changes: 16 additions & 0 deletions smile/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,22 @@ tree model)
</properties>

<dependencies>
<!-- We depend on Jackson core components; annotations optionally/for tests -->
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>tools.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>

<!-- for testing we need annotations -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<scope>provided</scope>
</dependency>
</dependencies>

<build>
Expand Down