Skip to content

Fix #554: enforce/document immutability of CsvSchema #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowtowncoder merged 2 commits into from
Mar 31, 2025
Merged

Fix #554: enforce/document immutability of CsvSchema #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3062db
Fix #554: enforce/document immutability of CsvSchemea
cowtowncoder Mar 31, 2025
162fb47
Minor wording change
cowtowncoder Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions csv/src/main/java/com/fasterxml/jackson/dataformat/csv/CsvSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
/**
* Simple {@link FormatSchema} sub-type that defines properties of
* a CSV document to read or write.
* Instances are thread-safe and immutable (explicitly immutable since 2.19,
* but thread-safe since 2.0).
* <p>
* Properties supported currently are:
*<ul>
* <li>{@code columns} (List of ColumnDef) [default: empty List]: Ordered list of columns (which may be empty, see below).
Expand Down Expand Up @@ -885,9 +888,9 @@ protected void _checkIndex(int index) {
/**
* Bitflag for general-purpose on/off features.
*
* @since 2.5
* @since 2.5 (final since 2.19)
*/
protected int _features = DEFAULT_ENCODING_FEATURES;
protected final int _features;

protected final char _columnSeparator;

Expand Down
6 changes: 6 additions & 0 deletions release-notes/CREDITS-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,3 +289,9 @@ Robert DiFalco (@rdifalco)

* Reported #31: Header names seem to be trimmed
(2.19.0)

Gili Tzabari (@cowwoc)

* Requested #554: (csv) Enforce, document thread-safety of `CsvSchema`
(2.19.0)

2 changes: 2 additions & 0 deletions release-notes/VERSION-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ Active Maintainers:
(contributed by Joo-Hyuk K)
#537: (yaml) Snakeyaml 2.4
(contributed by @pjfanning)
#554: (csv) Enforce, document thread-safety of `CsvSchema`
(requested by Gili T)

2.18.3 (28-Feb-2025)
2.18.2 (27-Nov-2024)
Expand Down