-
Notifications
You must be signed in to change notification settings - Fork 109
Add support for JsonUnwrapped #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I created the PR against 2.11 since this is the current stable branch, but it currently cannot be directly merged in master. |
|
||
String json = mapper.writeValueAsString(new HasUnwrapped<>(product)); | ||
|
||
System.out.println(json); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this line
First of all: thank you for this contribution! One quick question: do you think deserialization also works? If so, would be nice to just add code to read serialization back. Beyond that, merging into 2.11 is fine as no new functionality is added, but I suspect that a new feature merged into 2.12 (see #136) might make merging 2.11 -> 2.12 bit difficult. And then the final thing: unless I have asked for (I do not think I have, but apologies if I have) CLA yet, I would need one filled: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf this only needs to be done once before the first contribution and then it works for all future PRs. Once again, thank you for contributing this fix; looking forward to merging it! |
Ah never mind! I noticed you already sent the CLA, thank you very much! |
@cowtowncoder thank you for your comments. I changed the tests so they are now not printing to the console and to read back the serialized json. Note that I force pushed my changes to keep them in a single commit. |
@tsachev Excellent, thank you. I will have one more look before merging. |
This PR was merged into 2.11 branch, and 2.11.1 was released but I don't see the changes in there: |
2.11.1 was released on 25-Jun-2020 as per release notes, so this will go in 2.11.2, not yet released. |
Here is PR that adds support for
@JsonUnwrapped
properties that are proxies.Fix for #97