Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix apns_protocol_factory being wrapped in tuple #66

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix apns_protocol_factory being wrapped in tuple #66

merged 1 commit into from
Jul 5, 2024

Conversation

pomali
Copy link
Contributor

@pomali pomali commented Jul 2, 2024 •
edited
Loading

PR should fix mistake where apns_protocol_factory is wrapped in tuple. It crashes APNsKeyConnectionPool._create_connection() and manifests itself in pretty unclear way.

...
ERROR 2024-07-02 11:57:47,628 connection aioapns 22419 6191968256 Could not connect to server: 'tuple' object is not callable
WARNING 2024-07-02 11:57:47,629 connection aioapns 22419 6191968256 Could not send notification a5dc24f9-946c-488a-bd4f-e408049831cb: ConnectionError
ERROR 2024-07-02 11:57:48,631 connection aioapns 22419 6191968256 Failed to send after 5 attempts.

@aalbinati aalbinati mentioned this pull request Jul 5, 2024
Closed
@Fatal1ty Fatal1ty merged commit bc7fd52 into Fatal1ty:master Jul 5, 2024
4 checks passed
@aalbinati
Copy link

I'm having the same problem, using 3.2 until this is fixed. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pomali @aalbinati @Fatal1ty