Fix AttributeError when using generic SerializableType subclass #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feuermurmel
changed the title
Feuermurmel
force-pushed
the
michi/issue-274
branch
from
9ad4e3e to
deb5cc1
Compare
When using PEP 695 syntax to create a generic class, some private attributes are set up by the runtime in __init_subclass__(). Those attributes are needed when specializing the generic class. SerializableType did not call super().__init_subclass__() and thus those attributes were missing, leading to an AttributeError.
Feuermurmel
force-pushed
the
michi/issue-274
branch
from
deb5cc1 to
761579d
Compare
|
Looks good, thank you for your contribution! |
|
Sure! 😊 Thanks for acting on it so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using PEP 695 syntax to create a generic class, some private attributes are set up by the runtime in
__init_subclass__(). Those attributes are needed when specializing the generic class.SerializableType did not call
super().__init_subclass__()and thus those attributes were missing, leading to an AttributeError.Fixes #274