test(native): isolate fallback descriptor scan after fork - #73
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe descriptor-policy fallback test now runs ChangesDescriptor policy fallback test
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This test-only change isolates fallback descriptor scanning without changing production behavior, so no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This fixes an existing native-runner test race that can fail the parallel workspace suite with
EBADF.Command::pre_exec, matching its production post-fork execution context instead of mutating the shared parent test process.close_rangefast path to bypass it.CLOEXECdescriptor is closed after exec.No production function, error policy, public API, or runtime behavior changes.
Validation
Safety
Summary by CodeRabbit