feat: CQDG-392 handle affiliation empty #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulous
requested review from
ethienneroy,
evans-g-crsj,
adipaul1981 and
celinepelletier
atoulous
force-pushed
the
feat/cqdg-392b
branch
from
4b65a3a
to
e048c2e
Compare
atoulous
commented
Sep 27, 2023
src/db/models/User.ts
Outdated
| is: NAME_REGEX, | ||
| }, | ||
| allowNull: true, | ||
| validate: { validate: (value: string) => (value ? NAME_REGEX.test(value) : true) }, |
There was a problem hiding this comment.
je fais ca car NAME_REGEX fail avec la value vide ''
There was a problem hiding this comment.
value === '' || NAME_REGEX.test(value)
so that we avoid falsy values such as undefined or similar.
evans-g-crsj
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.