Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversions to and from MongoDB driver #72

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Dec 24, 2024

No description provided.

@mergify mergify bot assigned AlekSi Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 81.03448% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.88%. Comparing base (d102839) to head (ed30e35).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
wirebson/bson.go 81.03% 16 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   62.98%   63.88%   +0.89%     
==========================================
  Files          41       41              
  Lines        2221     2337     +116     
==========================================
+ Hits         1399     1493      +94     
- Misses        646      662      +16     
- Partials      176      182       +6     
Files with missing lines Coverage Δ
wirebson/bson.go 82.22% <81.03%> (-7.26%) ⬇️
Flag Coverage Δ
test 63.88% <81.03%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Dec 24, 2024
@AlekSi AlekSi requested a review from Copilot December 24, 2024 16:03
@AlekSi AlekSi marked this pull request as ready for review December 24, 2024 16:03

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

bits.go:30

  • The use of 'range' with an integer is incorrect. It should be 'for shift := 0; shift < 32; shift++' to iterate from 0 to 31.
for shift := range 32 {
Copy link

mergify bot commented Dec 25, 2024

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added conflict PRs that have merge conflicts and removed conflict PRs that have merge conflicts labels Dec 25, 2024
@AlekSi AlekSi requested a review from Copilot December 25, 2024 11:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported
@AlekSi AlekSi merged commit f782d49 into FerretDB:main Dec 25, 2024
9 checks passed
@AlekSi AlekSi deleted the driver branch December 25, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant