fix: createStorageContext without getClientDataSetsWithDetails #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | b14e663 | Commit Preview URL Branch Preview URL |
Nov 13 2025, 08:05 PM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my attempt to fix the issue brought up by #435
tested in filecoin-pin-website and saw a reduction in calls (when dataSetId existed) from 60 to 16
will need review from someone with more knowledge of the codebase
Note: without using
storage.createContextFromDataSetId, the calls in filecoin-pin-website was still 53.. (only the fix toresolveByDataSetId) because there are still some places calling thegetClientDataSetsWithDetailshotpath: