Reduce hook installation tests #1118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
force-pushed
the
reduce-hook-installation-tests
branch
2 times, most recently
from
5dd20a9 to
91f625c
Compare
olusoladavid
approved these changes
Nov 6, 2025
Contributor
olusoladavid
left a comment
olusoladavid
left a comment
There was a problem hiding this comment.
lgtm, thanks - one question about async usage
|
|
||
| // the resulting installations and/or conflicts from `Hook.mergeChildInstallations` and `p` | ||
| export async function reducePluginHookInstallations( | ||
| export function reducePluginHookInstallations( |
Contributor
There was a problem hiding this comment.
question: what was the original reason for making this function async? performance?
Member
Author
There was a problem hiding this comment.
have been trying to work it out; i think originally i was thinking that the merge/override methods might need to be async? but they don't
apaleslimghost
force-pushed
the
reduce-hook-installation-tests
branch
from
91f625c to
c14974b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce-installations.tsdidn't have tests. originally this branch was going to be fixing the conflict bug between multiple installations from the same plugin but i could not get that working. i'm going to try a different approach for adding the config for the "PR closed" workflow config.