first class JUnit support for Mocha/Jest #1133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
requested review from
a team and
ft-dependency-auto-merger
as code owners
ivomurrell
reviewed
Nov 12, 2025
plugins/jest/src/tasks/jest.ts
Outdated
|
|
||
| this.logger.info(`running jest ${args.join(' ')}`) | ||
| const child = fork(jestCLIPath, args, { silent: true, cwd }) | ||
| const child = fork(jestCLIPath, args, { silent: true, cwd, env }) |
Contributor
There was a problem hiding this comment.
question: should env be merged with process.env?
Member
Author
There was a problem hiding this comment.
oh yep good point, i forgot fork defaulted to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than hardcoding env vars for both frameworks in the orb, let's configure this directly in the tasks