-
Notifications
You must be signed in to change notification settings - Fork 0
fix: QA 수정사항 반영 #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fix: QA 수정사항 반영 #113
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6f00438
[fix] 보호장소, 발견장소 데이터 수정
ikseong00 bcd27bc
[fix] 하단바(BNV) 노출 로직 수정
ikseong00 7a28f91
[feat] bg_radius_20 배경 색상 제거
ikseong00 f033342
[refactor] 보호 장소 UI 수정
ikseong00 bed4636
[fix] 디스코드 에러 로깅 범위 수정
ikseong00 e5ff60c
[feat] 게스트 로그인 버튼 UI 복원
ikseong00 0a23bc3
[fix] 지도 위치 정보 없을 시 지도 숨김 처리
ikseong00 dffa147
[refactor] 게스트 로그인 토스트 메시지 수정
ikseong00 80b9257
[feat] refreshToken 추가
ikseong00 40cd83a
[refactor] 메인 컬러 변경
ikseong00 3ce4483
[fix] 회원 탈퇴 완료 시 토큰을 제거하는 것으로 수정
ikseong00 e91d2c2
[feat] 조회 createdAt 필드 추가
ikseong00 76944d8
[refactor] 온보딩 프로필 설정 로직 제거
ikseong00 a8886ac
[refactor] 스플래시 화면 레거시 색상 적용
ikseong00 1bca665
[fix] 마이페이지 프로필 응답값 수정
ikseong00 a7b9f3a
[refactor] 회원가입 API 요청 형식 변경
ikseong00 af8f1a5
[feat] 토큰 재발급 API 구현
ikseong00 c511eb7
[feat] 토큰 재발급 로직 구현
ikseong00 de3647c
[feat] 게스트 로그인 시 이미 가입된 계정이면 에러 메시지 표시
ikseong00 450d33b
[feat] 게스트 유저 제보 기능 제한
ikseong00 b96e2d9
[feat] 홈 화면 스크롤 최상단 이동 버튼 제거
ikseong00 3bfa6be
[chore] 앱 버전 정보 업데이트
ikseong00 d202b7f
[feat] Proguard 규칙 추가
ikseong00 25dc686
[feat] 게스트 유저 '내 제보 내역' 조회 기능 제한
ikseong00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
app/src/main/java/com/kuit/findu/data/dataremote/exception/ApiNotFoundException.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package com.kuit.findu.data.dataremote.exception | ||
|
|
||
| class ApiNotFoundException( | ||
| message: String, | ||
| ) : Exception(message) |
14 changes: 14 additions & 0 deletions
14
app/src/main/java/com/kuit/findu/data/dataremote/model/request/PostUserRequestDto.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package com.kuit.findu.data.dataremote.model.request | ||
|
|
||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class PostUserRequestDto( | ||
| @SerialName("nickname") | ||
| val nickname: String, | ||
| @SerialName("kakaoId") | ||
| val kakaoId: Long, | ||
| @SerialName("deviceId") | ||
| val deviceId: String, | ||
| ) |
10 changes: 10 additions & 0 deletions
10
app/src/main/java/com/kuit/findu/data/dataremote/model/request/TokenReissueRequestDto.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| package com.kuit.findu.data.dataremote.model.request | ||
|
|
||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class TokenReissueRequestDto( | ||
| @SerialName("refreshToken") | ||
| val refreshToken: String, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 12 additions & 0 deletions
12
...c/main/java/com/kuit/findu/data/dataremote/model/response/auth/TokenReissueResponseDto.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package com.kuit.findu.data.dataremote.model.response.auth | ||
|
|
||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class TokenReissueResponseDto( | ||
| @SerialName("accessToken") | ||
| val accessToken: String, | ||
| @SerialName("refreshToken") | ||
| val refreshToken: String, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 5948
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 54
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 54
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 232
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 149
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 2648
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 8260
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 978
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 3101
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 573
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 149
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 1484
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 54
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 867
🏁 Script executed:
Repository: FindYou-Kuit/FindYou-Android
Length of output: 134
패키지 전체 -keep은 축소/난독화 효과를 크게 줄 수 있어요
data/domain 패키지 전체를 보존하면 불필요한 클래스도 남아 APK 용량 증가 및 난독화 약화 가능성이 커요. data 패키지에는 128개 중 약 76개만
@Serializable로표시되어 있고, domain은 repository/usecase 인터페이스와 구현체들이 대부분이라 전체 보존이 필수는 아닙니다.기존 kotlinx.serialization 규칙(39-45줄)에서
KSerializer serializer(...)패턴으로 필요한 클래스만 검증하고 있으니, data의 serializable 모델들은 이미 보호되고 있습니다. 나머지 범위를 좁혀서 보존 대상을 명확히 하면, 난독화 효과를 더 높일 수 있어요.♻️ 범위 축소 예시
🤖 Prompt for AI Agents