Added open/close custom events (not callbacks), README, LICENSE and bug fixes #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply added namespaced open and close events via jQuery trigger method. Nothing more, nothing less.
This keeps the close button link from executing and putting nasty little hashes on the end of the URL for the current page. Nothing more, nothing less.
I took the liberty to reformat the spacing and indentation, as well as make the use of single and double quotes consistent and where single quotes were used in HTML tags, double quotes replaced them. Nothing more, nothing less.
Added the "how to" from the website to the README, along with the new event features, change log and authors info.
|
+1 bump...though I think it should be left as "PLUGIN" so as to keep it "lean" (pun intended) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this pull request is easier to do. I've added custom event triggers to both modal open and close from the modal_id, cleaned up quotes and spaces, fixed some bugs (multiple overlays, added preventDefaults, etc), fleshed out the README with How To and changelog. Finally, I added a LICENSE file.
Great job on the plugin, lean is the way to go!