Allow custom hint text at DefaultSearchView
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fintasys could you look into merging this? Thank you :) |
|
Yes, but sorry I haven't found time yet. There are a few things I want to check before allowing wordings directly in the configuration. You shouldn't be blocked by waiting for my review since you can just copy the default implementation, change the string and assign it to customSearchView property in the configuration. |
Fintasys
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses the issue of the 'Search' hint in DefaultSearchView being fixed and untranslatable. The goal is to modify this hint to be customizable, thereby enabling its translation into various languages.