revert kotlin version back to 1.7.10 #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I provided already a branch with the downgrade here. But so far I haven't heard from anyone that it fixes the issue |
|
Last week we moved our project to 1.9.22 so get emoji_picker_flutter to
compile our production app that uses 100+ packages with 600k android
installs. Moving to 1.9.22, Gradle 7 produced warnings of mixing old java
with java 17 (used by 1.9.22). Fyi these warnings are defaulted to errors
in Gradle 8.
Our user perceived crash rate had been in the normal range of 0.15%.
Updating our user base to the 1.9.22 build the crash rate began climbing,
hit 6% within 2 days. 99.9% of the crashes were in android library code
when resuming the app from background.
Crash rate did not change with the our 500k iOS users. So we looked at
android specific changes between releases.
We created a fork of emoji_picker_flutter setting kotlin to 1.7.10 and
reverted our project back to 1.7.10. The java old/new mix warnings go
away. We released this version of the app 2 days ago and crash rate has
been restored to sub 0.15%.
…On Tue, Mar 5, 2024, 2:18 AM Stefan Humm ***@***.***> wrote:
I provided already a branch with the downgrade here. But so far I haven't
heard from anyone that it fixes the issue
#189 (comment)
<#189 (comment)>
—
Reply to this email directly, view it on GitHub
<#191 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXMGLNVKBCK3N7ETOEWOKDYWWLXDAVCNFSM6AAAAABEFVVBECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZYGQYTMNJVGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It works in my case. |
|
This pull request (#192) appears to offer a more sustainable solution for the future. Let's try implementing it before deciding whether to revert to the Kotlin version. |
|
This still doesn't work. It forces me to update kotlin which then blows up the entire rest of the flutter toolchain for Android. You're pushing people into a non-standard environment that isn't the default. |
|
@JohnGalt1717 have you tried the most recent release? If it doesn't work, please file another issue 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kotlin version 1.9.22 compiles code with Java 17 and we're getting java 8 / 17 warnings from gradle 7. Those warnings are errors in gradle 8.
Latest stable flutter and it's packages are using 1.7.10.