Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search with the emoji itself too #206

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

Shawn-sudo
Copy link
Contributor

Before: Typing the emoji itself doesn't show the emoji as a search result

  • Example:
    • Screenshot_20240625-231505 Screenshot_20240625-232204
  • Typing "👋" won't give "👋" as an option -> not the best user experience

Solution that I'm proposing: modify the search logic a bit to find the emoji that matches exactly

  • One problem of my code: It works well for most of the emojis, but there are two or three emojis that doesn't work (❤️ "red heart" is a big one)

Copy link
Owner

@Fintasys Fintasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution!

@Fintasys Fintasys merged commit f341b4f into Fintasys:master Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants