Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow undefined routes #42

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Allow undefined routes #42

merged 3 commits into from
Dec 11, 2024

Conversation

TheTeaCat
Copy link
Member

Describe your changes

Implements a new option for the middleware - AllowUndefinedRoutes - which allows requests to routes not defined in the OpenAPI specification to pass through.

Issue ticket number and link

https://firetail-io.atlassian.net/browse/FIRE-2897

Checklist before requesting a review

  • I have resolved any merge conflicts
  • I have run tests locally and they pass
  • I have linted and auto-formatted the code
  • If there is new or changed functionality, I have added/updated the tests
  • If there is new or changed functionality, I have added/updated the documentation

Sorry, something went wrong.

@TheTeaCat TheTeaCat self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.36%. Comparing base (e49384e) to head (8685eeb).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
middlewares/http/middleware.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   84.08%   83.36%   -0.73%     
==========================================
  Files           8        8              
  Lines         553      565      +12     
==========================================
+ Hits          465      471       +6     
- Misses         75       79       +4     
- Partials       13       15       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTeaCat TheTeaCat merged commit 45f4dbb into main Dec 11, 2024
2 of 3 checks passed
@rileyfiretail rileyfiretail deleted the allow-undefined-routes branch December 11, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants