Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip values #43

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Strip values #43

merged 8 commits into from
Jan 13, 2025

Conversation

TheTeaCat
Copy link
Member

Describe your changes

Implements two options that allow you to enable the stripping of all values from JSON request and/or response payloads before passing them to whatever LogBatchCallback is used.

Issue ticket number and link

https://firetail-io.atlassian.net/browse/FIRE-2922

Checklist before requesting a review

  • I have resolved any merge conflicts
  • I have run tests locally and they pass
  • I have linted and auto-formatted the code
  • If there is new or changed functionality, I have added/updated the tests
  • If there is new or changed functionality, I have added/updated the documentation

@TheTeaCat TheTeaCat self-assigned this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 80.32787% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (45f4dbb) to head (bd7aad2).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
logging/batch_logger.go 77.77% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   83.36%   82.79%   -0.58%     
==========================================
  Files           8        8              
  Lines         565      616      +51     
==========================================
+ Hits          471      510      +39     
- Misses         79       85       +6     
- Partials       15       21       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rileyfiretail
rileyfiretail previously approved these changes Jan 13, 2025
@TheTeaCat TheTeaCat merged commit 9c914c1 into main Jan 13, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants