Rich text copy/cut/paste #237

kofifus · 2016-02-16T00:59:39Z

Notes:

Does not work when Chorme developer tools is open (not sure why), will revert to CM copy
requires a recent codemirror > 5.13.2
Make sure you have lineWiseCopyCut:false in your CM options

mikelehen · 2016-02-16T04:07:49Z

Thanks for this! I'll take a look and review it when I get a chance. Unfortunately I'm pretty busy with other projects at the moment, so there may be a bit of a delay.

kofifus · 2016-03-23T05:14:56Z

CodeMirror 5.12 now supports copy & cut events which makes the firepad code simpler. I have updated the PR accordingly and also enhanced some styles support.

New plnkr in http://plnkr.co/edit/fMroiV79FvkCJF590dpj

Obviously you need CodeMirror 5.12

kofifus · 2016-03-28T04:36:53Z

Please hold on with merging this. There may be a better way, see https://discuss.codemirror.net/t/clipboarddata-setdata/695

kofifus · 2016-04-05T01:47:46Z

I have updated the PR again with much better results for mac OSX and better style handling on paste. I think I will leave this for now unless any issues are found. I hope this can be merged soon.

Updated http://plnkr.co/edit/PgMKReE64a8Nc4HiTx4I?p=preview

Rember this PR requires Codemirror > 5.13
you also want cm option lineWiseCopyCut:false

jbrecht · 2016-04-15T17:26:19Z

@kofifus - we have a fork of firepad for some customizations we are making to it for our learning/therapy application. this copy/paste functionality is something we'd love to have. if you are open to it, I'd love to pull this branch into our fork and I can do some experimentation and further code review. https://github.com/presencelearning/firepad

kofifus · 2016-04-15T21:32:11Z

yeah sure do I need to do anything ?

jbrecht · 2016-04-18T17:53:44Z

lib/firepad.js

@@ -90,7 +90,6 @@ firepad.Firepad = (function(global) {
    }
    this.client_ = new EditorClient(this.firebaseAdapter_, this.editorAdapter_);

-    var self = this;


deleting this definition of 'self' breaks a lot of things later on

jbrecht · 2016-04-18T20:12:20Z

@kofifus - this is not working for me. After I fixed the missing 'self' definition, I now run into an issue where onCodeMirrorPaste_ quits early because it gets no 'html'. The clipboardData in the event it receives has an empty 'types' array. So then I went to look at what happens in onCodeMirrorCopyCut_. If I log the final e.clipboardData, it monetarily has a 'types' array of length 1, but it becomes length 0 shortly after the call exits, so something is wiping it out. (Using Chrome 50 on OS X.)

kofifus · 2016-04-18T21:57:26Z

apologies the removed 'self' crept in from another PR I'm working on, fixed.

The other problem you specify may be a mac OS problem, can you check with http://plnkr.co/edit/PgMKReE64a8Nc4HiTx4I?p=preview and see how it goes there and let me know pls ?

jbrecht · 2016-04-18T22:34:35Z

The Plunker demo works in Firefox (45) but fails in Chrome (50). I'm on OS X 10.10.5.

kofifus · 2016-04-18T22:38:11Z

ok, this may be related to https://bugs.chromium.org/p/chromium/issues/detail?id=552975

I should have access to a mac in the next few days and will have a look thx

kofifus · 2016-04-23T01:05:12Z

jbrecht, I am checking on MacBook Pro / OS X Yosemite 10.10.1 / Chrome version 50.0.2661.86 (64-bit) using the plunkr.

Everything seems to work ok, that is copy/paste of text with rich text attributes (bold etc) works properly.

Can you test again ? what exact computer / OSX version / Chrome version you're using ?

kofifus · 2016-04-24T12:09:59Z

further commits to fix a problem in parseHtml that resulted in buggy behavior when pasting a line with leading spaces

new plunkr: http://plnkr.co/edit/MqAdtT1eNCdyheWaKnGO?p=preview

jbrecht · 2016-05-16T23:46:10Z

This works for me, although a unit test is currently failing

kofifus · 2016-05-17T00:25:16Z

Thx John, the unit auto build system has issues with npm package versioning etc .. if you feel like helping that will be great:)

PS there still seems to be issues with rich text copy/paste in mac Chrome which I'm looking into

kofifus · 2016-05-19T23:58:43Z

Updated the code to correctly remove sentinels when doing plain text copy/cut
(http://plnkr.co/edit/MqAdtT1eNCdyheWaKnGO)

No further known issues at this stage :)

llamerr · 2016-06-15T09:47:27Z

I also interested in this pull request, I squashed it and merged into my version (1 year old, needed to be updated), after solving few minor conflicts it's working fine. But it's not working in Edge due to lack of 'text/html' support for Clipboard API. When I replaced it with 'text' in setData/getData it started working in Edge and continued working in Chrome. I haven't tested it extensively yet so not sure if that can be kept, but maybe it can detect if after using setData clipboard contains something, and if not, then re-try with 'text' instead of 'text/html'?

kofifus · 2016-06-15T10:06:52Z

thx ... interesting

in https://html.spec.whatwg.org/multipage/interaction.html#dom-datatransfer-getdata I find:

'If format equals "text", change it to "text/plain".'
that means that if edge complies with the standard above, if you change "text/html" to "text" you will get "text/plain" that is you will have plain text copy/paste and not rich text copy/paste.

Do you find that you still get rich text copy/paste (ie bold/italics/etc) with that change ? I find that strange ..

llamerr · 2016-06-15T10:33:33Z

Yes, I think it's working because you only using Clipboard API for storing text, not actually for copy/pasting it (I'm new to it and haven't read docs yet, so not sure if there other ways to working with it and what clipboard contains when you copy html)
val=fp.getHtmlFromSelection(); for copy
and
fp.insertHtmlAtCursor(html); for paste
is used, so that value is string and can be stored as string inside clipboard.

kofifus · 2016-06-15T10:40:53Z

ha you're right, this will work within firepad, but it will not paste rich text outside (for example into a gmail msg), or the other way around .. can you check ?

llamerr · 2016-06-15T10:46:04Z

Yes, you're right, that's the difference! It's pasting raw html ('<span ...') in case of 'text' and decorated text in case of 'text/html', so seems not the best option to use that by default.

kofifus · 2016-06-15T10:53:05Z

another win for microsoft ...

still you can test for edge and use 'text' in that case which will give you rich copy text inside firepad which is much better than nothing

…nd added changes for copy/cut/paste buttons using same functionality

kofifus · 2016-06-23T01:07:52Z

Michael, I'm about to update this with a few more changes and want to use the new FireBase version.
Is there a way for you to provide a public FB instance (config = { apiKey: .., authDomain: ..., databaseURL: ..., storageBucket: ... };) that I can use for the plunkr demo ?

As this PR seems to be important and needs a lot of testing this will be very helpful.

Thx!

mikelehen · 2016-06-23T15:41:49Z

Since we don't need authentication / security rules, you should actually be able to just use https://firepad.firebaseio-demo.com as the databaseURL and set the other fields to dummy values (empty string or whatever).

kofifus · 2016-06-23T23:45:31Z

I committed further updates to the code -

I removed the surrounding span around the copied clip that had 'default' styles like font family/size/etc. This span caused issues when pasting into rich text editors (ie openoffice) and is not essential. FireFox for example does not add such default attributes into a copy clip (chrome does). This made the code much cleaner and works better when pasting outside FP.

The original FP code serializeHTML replaced all leading trailing and consecutive spaces with nbsp .. this had a negative effect of creating hard spaces when pasting into for example open office. I now removed that code and instead serializeHTML adds <pre> .. </pre> around the copy div

Also the copy clip will now be saved in the clipboard in both html and text formats. This allows copying rich text from FP and pasting into non rich text editors or rich text editors that cannot read html clips from the clipboard (ie wordpad).

Plunkr: plunkr

mikelehen · 2016-06-23T23:55:36Z

Awesome. Those sound like good improvements. :-)

On Thu, Jun 23, 2016 at 4:45 PM, Kofifus [email protected] wrote:

I committed further updates to the code -

I removed the surrounding span around the copied clip that had 'default'
styles like font family/size/etc. This span caused issues when pasting into
rich text editors (ie openoffice) and is not essential. FireFox for example
does not add such default attributes into a copy clip (chrome does). This
made the code much cleaner and works better when pasting outside FP.

Also the copy clip will now be saved in the clipboard in both html and
text formats. This allows copying rich text from FP and pasting into non
rich text editors or rich text editors that cannot read html clips from the
clipboard (ie wordpad).

Plunkr: plunkr http://plnkr.co/edit/dcu96xxQYA7yB0htNqu6?p=preview

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#237 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAMmHPDOpseEO2YZrPDiYJ5aQlX8YOfdks5qOxqcgaJpZM4HaxCz
.

Haraldlons · 2021-06-23T07:51:13Z

Thanks for the work @kofifus!

I'm not able to get any of the plunkr to work, copying from the editor and pasting into gmail/slack.

Using Google Chrome (Version 90.0.4430.212 (Official Build) (64-bit) (Ubuntu/Linux))

Is there any update on this PR?

This feature would be highly valuable to my team!

kofifus · 2021-06-23T08:51:49Z

well it's been 5 years and TBH I totally gave up in firepad as it's not really supported .. you can find projects binding the amazing ProseMirror to FireBase .. sorry can't help

samtstern · 2021-06-23T09:17:55Z

@kofifus I am sorry this PR was not given the attention it deserved when you originally filed it. If anyone wants to try and revive this PR I would be happy to review it.

We've tried to clarify the state of this project in the README since then: https://github.com/FirebaseExtended/firepad#status

Basically we (Firebase) are not actively working on this project however we're happy to accept Pull Requests and release new updates when required. There are many people who depend on Firepad and we believe it to be a mostly healthy library as-is.

samtstern · 2021-06-23T13:02:58Z

Ah whoops! I meant this link: https://github.com/FirebaseExtended/firepad#status

Rich text copy/cut/paste

5ba7bee

kofifus mentioned this pull request Feb 16, 2016

Copy/Paste should preserve styling #35

Open

kofifus added 3 commits March 23, 2016 15:51

Update firepad.js

6ce1dc9

Update rich-text-codemirror.js

88032a5

Update firepad.js

30ff490

kofifus added 7 commits April 5, 2016 11:00

Update firepad.js

af53b7a

Update rich-text-codemirror.js

59643cb

Update rich-text-codemirror.js

fdbd7d9

Update parse-html.js

acad413

Update parse-html.js

f703475

Update headless.js

f2f9131

Update firepad.js

8366a57

jbrecht reviewed Apr 18, 2016
View reviewed changes

Update firepad.js

21ad1f7

kofifus added 4 commits April 24, 2016 17:46

Update rich-text-codemirror.js

ed47fe8

Update firepad.js

92ce779

Update parse-html.js

d39f573

Update parse-html.js

1178b50

kofifus added 5 commits April 24, 2016 22:24

Update firepad.js

ed6d16c

Update firepad.js

5f606e5

Update package.json

546d7a0

Update firepad.js

0e163e7

Update firepad.js

0e612ee

Update rich-text-codemirror.js

2dce1d1

llamerr pushed a commit to invigos/firepad that referenced this pull request Jun 15, 2016

PRDEV-944 #comment squashed/applied patch from FirebaseExtended#237 a…

9e0e864

…nd added changes for copy/cut/paste buttons using same functionality

Update rich-text-codemirror.js

8fb5aaf

kofifus added 4 commits June 24, 2016 10:44

Update rich-text-codemirror.js

173f625

Update serialize-html.js

82504b4

Update rich-text-codemirror.js

bf98f1b

Update serialize-html.js

9c73df8

This comment has been minimized.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rich text copy/cut/paste #237

Rich text copy/cut/paste #237

kofifus commented Feb 16, 2016 •

edited

Loading

mikelehen commented Feb 16, 2016

kofifus commented Mar 23, 2016

kofifus commented Mar 28, 2016

kofifus commented Apr 5, 2016

jbrecht commented Apr 15, 2016

kofifus commented Apr 15, 2016

jbrecht Apr 18, 2016

jbrecht commented Apr 18, 2016

kofifus commented Apr 18, 2016

jbrecht commented Apr 18, 2016

kofifus commented Apr 18, 2016

kofifus commented Apr 23, 2016 •

edited

Loading

kofifus commented Apr 24, 2016 •

edited

Loading

jbrecht commented May 16, 2016

kofifus commented May 17, 2016

kofifus commented May 19, 2016

llamerr commented Jun 15, 2016 •

edited

Loading

kofifus commented Jun 15, 2016 •

edited

Loading

llamerr commented Jun 15, 2016 •

edited

Loading

kofifus commented Jun 15, 2016 •

edited

Loading

llamerr commented Jun 15, 2016 •

edited

Loading

kofifus commented Jun 15, 2016

kofifus commented Jun 23, 2016 •

edited

Loading

mikelehen commented Jun 23, 2016

kofifus commented Jun 23, 2016 •

edited

Loading

mikelehen commented Jun 23, 2016

Haraldlons commented Jun 23, 2021

kofifus commented Jun 23, 2021

samtstern commented Jun 23, 2021 •

edited

Loading

This comment has been minimized.

samtstern commented Jun 23, 2021

Rich text copy/cut/paste #237

Are you sure you want to change the base?

Rich text copy/cut/paste #237

Conversation

kofifus commented Feb 16, 2016 • edited Loading

mikelehen commented Feb 16, 2016

kofifus commented Mar 23, 2016

kofifus commented Mar 28, 2016

kofifus commented Apr 5, 2016

jbrecht commented Apr 15, 2016

kofifus commented Apr 15, 2016

jbrecht Apr 18, 2016

Choose a reason for hiding this comment

jbrecht commented Apr 18, 2016

kofifus commented Apr 18, 2016

jbrecht commented Apr 18, 2016

kofifus commented Apr 18, 2016

kofifus commented Apr 23, 2016 • edited Loading

kofifus commented Apr 24, 2016 • edited Loading

jbrecht commented May 16, 2016

kofifus commented May 17, 2016

kofifus commented May 19, 2016

llamerr commented Jun 15, 2016 • edited Loading

kofifus commented Jun 15, 2016 • edited Loading

llamerr commented Jun 15, 2016 • edited Loading

kofifus commented Jun 15, 2016 • edited Loading

llamerr commented Jun 15, 2016 • edited Loading

kofifus commented Jun 15, 2016

kofifus commented Jun 23, 2016 • edited Loading

mikelehen commented Jun 23, 2016

kofifus commented Jun 23, 2016 • edited Loading

mikelehen commented Jun 23, 2016

Haraldlons commented Jun 23, 2021

kofifus commented Jun 23, 2021

samtstern commented Jun 23, 2021 • edited Loading

This comment has been minimized.

samtstern commented Jun 23, 2021

kofifus commented Feb 16, 2016 •

edited

Loading

kofifus commented Apr 23, 2016 •

edited

Loading

kofifus commented Apr 24, 2016 •

edited

Loading

llamerr commented Jun 15, 2016 •

edited

Loading

kofifus commented Jun 15, 2016 •

edited

Loading

llamerr commented Jun 15, 2016 •

edited

Loading

kofifus commented Jun 15, 2016 •

edited

Loading

llamerr commented Jun 15, 2016 •

edited

Loading

kofifus commented Jun 23, 2016 •

edited

Loading

kofifus commented Jun 23, 2016 •

edited

Loading

samtstern commented Jun 23, 2021 •

edited

Loading