Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes comparisons from the FHIR types, in favor of using the comparisons on the CQL types. Also, it simplifies the public surface of the CQL types:
IToSystemPrimitive
for consistently converting from a FHIR primitive to a CQL primitive.@Kasdejong : The last feature will make sure that doing comparisons in FhirPath is a simple
IToSystemPrimitive.TryConvertToSystemType()
plus +TryCompare()
. We should refactor that in the FP engine.Still Todo:
null
if the Value of the primitive was null. I have now removed that, but double check that that makes sense. Esp with TryXXX: would you return false if you would return null if there is no value, or is that allowed?Fixes #2936, also fixes #2932.