Skip to content

Conversation

@ydai-hub
Copy link

@ydai-hub ydai-hub commented Nov 14, 2025

Added iFlow CLI commands and documentation link.
we have already supported openSpec in iFLOW CLI, https://platform.iflow.cn/agents/workflow-detail?id=114.

Summary by CodeRabbit

  • New Features

    • Added iFlow CLI support across tool listings, configurators, and slash-command integrations.
  • Documentation

    • Updated README to list iFlow CLI with commands and docs link.
    • Added iFlow scenario to CLI init documentation describing slash-command file creation and templates.
  • Tests

    • Added tests covering iFlow templates, configuration state, and update/refresh behaviors for slash-command files.

✏️ Tip: You can customize this high-level summary in your review settings.

dkmos2016 and others added 5 commits November 4, 2025 14:26
…sion-AI#268))

Add iFlow to the Native Slash Commands table in the README. iFlow support was implemented but was missing from the documentation.
Added iFlow CLI commands and documentation link.
@ydai-hub ydai-hub requested a review from TabishB as a code owner November 14, 2025 04:01
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 14, 2025

Walkthrough

Adds iFlow support: README entry, an iFlow AI_TOOLS entry, new ToolConfigurator and SlashCommandConfigurator (with registry registrations), OpenSpec scenario, and tests for init/update behaviors. No public API signatures changed.

Changes

Cohort / File(s) Summary
Docs
README.md
Added iFlow row under Supported AI Tools with command examples and docs link; mentioned among tools with native slash commands.
Core config
src/core/config.ts
Inserted { name: 'iFlow', value: 'iflow', available: true, successLabel: 'iFlow' } into exported AI_TOOLS.
Tool configurator
src/core/configurators/iflow.ts, src/core/configurators/registry.ts
New IflowConfigurator class implemented and instantiated; registered under key iflow in the configurator registry.
Slash command configurator
src/core/configurators/slash/iflow.ts, src/core/configurators/slash/registry.ts
New IflowSlashCommandConfigurator added (maps proposal/apply/archive to files and frontmatter); instantiated and registered in slash configurator registry.
OpenSpec scenario
openspec/specs/cli-init/spec.md
Added iFlow scenario describing creation of .iflow/commands/* files populated from templates and wrapped with OpenSpec markers.
Tests
test/core/init.test.ts, test/core/update.test.ts
Added tests covering iFlow init, template creation, marker updates, and OpenSpec update behaviors; integrated alongside existing tool tests.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant CLI as CLI / README
  participant Registry as ConfiguratorRegistry
  participant IflowCfg as IflowConfigurator
  participant SlashCfg as IflowSlashConfigurator
  participant Template as TemplateManager
  participant FS as FileSystemUtils

  CLI->>Registry: request configurator for "iflow"
  Registry->>IflowCfg: return IflowConfigurator
  IflowCfg->>Template: fetch Claude template for IFLOW.md
  Template-->>IflowCfg: template content
  IflowCfg->>FS: update IFLOW.md between OPENSPEC_MARKERS
  FS-->>IflowCfg: write result

  CLI->>Registry: request slash configurator for "iflow"
  Registry->>SlashCfg: return IflowSlashConfigurator
  SlashCfg->>Template: fetch slash command templates
  Template-->>SlashCfg: command content/frontmatter
  SlashCfg->>FS: create/update `.iflow/commands/...` with markers
  FS-->>SlashCfg: write result
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Focus review on:
    • src/core/configurators/iflow.ts — marker boundaries and TemplateManager usage.
    • src/core/configurators/slash/iflow.ts — file path/frontmatter consistency with other tools.
    • Tests (test/core/init.test.ts, test/core/update.test.ts) — ensure expectations and fixtures match behavior.

Possibly related PRs

Suggested reviewers

  • TabishB
  • Israel-Laguan

Poem

🐇
I hopped into code with a cheerful spin,
Planted an iflow row and tucked templates in,
Markers kept tidy, tests snug and bright,
Configurators ready to take flight,
A carrot for CI — hop, commit, win! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Add iFlow CLI to supported tools in README' is specific and accurately describes the initial documentation change, but the changeset now extends far beyond just README updates—it includes new configurators, registry entries, slash command implementations, and comprehensive test coverage. Consider updating the title to reflect the full scope: 'Add iFlow CLI support with configurators, slash commands, and tests' or similar, to better represent all changes made to the PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b8e5b3 and df8a4cb.

📒 Files selected for processing (2)
  • README.md (2 hunks)
  • openspec/specs/cli-init/spec.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-11-17T12:07:21.701Z
Learnt from: ydai-hub
Repo: Fission-AI/OpenSpec PR: 268
File: src/core/configurators/iflow.ts:14-21
Timestamp: 2025-11-17T12:07:21.701Z
Learning: In the OpenSpec repository, `TemplateManager.getClaudeTemplate()` returns a generic template that works for iFlow and other CLI tools, not just Claude-specific content. It's acceptable to use this template across different tool configurators.

Applied to files:

  • openspec/specs/cli-init/spec.md
🔇 Additional comments (1)
openspec/specs/cli-init/spec.md (1)

249-256: Scenario properly integrated and consistent with existing tool patterns.

The iFlow scenario correctly mirrors the established pattern (see RooCode at lines 241–247): directory structure (.iflow/commands/openspec-*.md), simple Markdown headings without YAML frontmatter, OpenSpec marker wrapping, and shared template population. The placement is logical and the scenario captures all necessary behavioral details for init and update workflows.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TabishB
Copy link
Contributor

TabishB commented Nov 14, 2025

@ydai-hub Do you guys want to create a selectable option here? I'm only getting a chance now to get around to reviewing the PR's.

Let me know if you still want to go through this: #268

If it's all good, I'm happy with just the docs change. (My concern is just someone doing openspec init and following the guide here won't see iflow as an option)

@ydai-hub ydai-hub marked this pull request as draft November 14, 2025 06:22
@ydai-hub
Copy link
Author

ydai-hub commented Nov 17, 2025

@ydai-hub Do you guys want to create a selectable option here? I'm only getting a chance now to get around to reviewing the PR's.

Let me know if you still want to go through this: #268

If it's all good, I'm happy with just the docs change. (My concern is just someone doing openspec init and following the guide here won't see iflow as an option)

Hello @TabishB. Could you help sign off this PR #268? I tested the change in that PR and found that it does work for iflow. And I will abandone this one. Thanks!
image
image

@TabishB
Copy link
Contributor

TabishB commented Nov 17, 2025

Hey @ydai-hub That PR currently has some conflicts and is missing some tests for the init/update flow

@ydai-hub
Copy link
Author

Hey @ydai-hub That PR currently has some conflicts and is missing some tests for the init/update flow

got it. Thank you for pointing it out

@antnesswcm
Copy link

Hope to support 'iflow-cli' soon, thank you

@ydai-hub ydai-hub changed the title Add iFlow CLI commands to README support iFlow CLI Nov 19, 2025
@ydai-hub ydai-hub marked this pull request as ready for review November 19, 2025 09:30
@ydai-hub ydai-hub changed the title support iFlow CLI Add iFlow CLI to supported tools in README Nov 19, 2025
@ydai-hub
Copy link
Author

ydai-hub commented Nov 19, 2025

hello @TabishB , I merged the conflicts and add UT in this PR, could you help review again. Thanks!

@ydai-hub ydai-hub marked this pull request as draft November 21, 2025 06:21
@ydai-hub ydai-hub closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants