Skip to content

Conversation

@TabishB
Copy link
Contributor

@TabishB TabishB commented Sep 6, 2025

Summary

  • Fixed test failures by ensuring TypeScript build runs before tests
  • Added comprehensive CI workflow for pull requests with matrix testing
  • Moved build step to run immediately after dependency installation

Problem

Tests were failing with ERR_MODULE_NOT_FOUND because the dist/ directory didn't exist when tests tried to run the CLI binary. The binary imports from dist/cli/index.js but the build hadn't run yet.

Solution

  1. Fixed release-publish.yml: Moved pnpm run build to run immediately after pnpm install and before any validation/test steps
  2. Added ci.yml workflow: Created comprehensive CI pipeline that runs on all PRs with:
    • Matrix testing across Node 18, 20, 22
    • Cross-platform testing (Ubuntu, macOS, Windows)
    • Type checking and build verification
    • Test coverage artifact upload
    • Proper caching for faster CI runs

Test plan

  • Verify workflow syntax is correct
  • CI workflow runs successfully on this PR
  • All tests pass with proper build order
  • Matrix testing works across Node versions and platforms

🤖 Generated with Claude Code

@TabishB TabishB merged commit 5c6ae8e into main Sep 6, 2025
4 checks passed
drvova pushed a commit to drvova/VovaSpec that referenced this pull request Oct 13, 2025
fix(ci): ensure build runs before tests in workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants