[bugfix] delete parameter not initialized for triton2.2 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongxin
reviewed
Feb 26, 2025
| @@ -93,6 +93,7 @@ def preload(self): | |||
| kwargs[k] = eval(v) | |||
| for k, v in cfg_ls[-attrs:]: | |||
| numargs[k] = eval(v) | |||
| numargs.pop("enable_persistent", None) | |||
There was a problem hiding this comment.
Could you add a comment line here describing this config option for reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Other
Type of Change
Bug Fix
Description
In the definition of triton.Config, attribute enable_persistent is not acclaimed as initialization parameter. While it's stored in FlagGems' config cache, resulting the error in preload.
Since in most cases, enable_persistent is set as default value, I ignore it when reconstructing triton.Config.
Issue
Progress
Performance