chore: use EC2 runners for the Private Cloud build#3015
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
khvn26
force-pushed
the
chore/use-ec2-runners-for-docker-build
branch
from
bc214ee to
d202ecb
Compare
zachaysan
left a comment
zachaysan
left a comment
There was a problem hiding this comment.
Everything looks good, just one small question.
|
|
||
| stop-runner: | ||
| needs: [start-runner, build-dockerhub] | ||
| if: ${{ always() }} |
There was a problem hiding this comment.
Just curious, why is the if: here even necessary?
There was a problem hiding this comment.
Without it the stop-runner job won't get launched in case of failures in any of the prior jobs.
There was a problem hiding this comment.
I had pretty much the same question on the similar PR in the edge API repo 😄
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3015 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 1048 1050 +2
Lines 30666 30674 +8
=======================================
+ Hits 29376 29384 +8
Misses 1290 1290 ☔ View full report in Codecov by Sentry. |
khvn26
force-pushed
the
chore/use-ec2-runners-for-docker-build
branch
from
d202ecb to
38c4961
Compare
|
|
||
| stop-runner: | ||
| needs: [start-runner, build-dockerhub] | ||
| if: ${{ always() }} |
There was a problem hiding this comment.
I had pretty much the same question on the similar PR in the edge API repo 😄
4 participants
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
This PR removes the need for me to have a GH runner running on my laptop to build the private cloud image.
How did you test this code?
Run workflow in CI.
Don't merge before...
GH_RUNNER_TOKENis set to a GitHub token with full repo-level permissions to this repo.