Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix added bugs in frontend deploy workflow #4979

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jan 8, 2025

Changes

Fixes a few minor bugs in the changes added by #4977

How did you test this code?

Ran the job with some of the steps commented out to verify that the secrets are passed through correctly.

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:43pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:43pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:43pm

@matthewelwell matthewelwell changed the title Ci/fix frontend deploy workflow ci: fix frontend deploy workflow Jan 8, 2025
@github-actions github-actions bot added the ci-cd Build, test and deployment related label Jan 8, 2025
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Uffizzi Preview deployment-59657 was deleted.

@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 8, 2025
@matthewelwell matthewelwell changed the title ci: fix frontend deploy workflow ci: fix added bugs in frontend deploy workflow Jan 8, 2025
@matthewelwell matthewelwell marked this pull request as ready for review January 8, 2025 13:44
@matthewelwell matthewelwell requested review from a team and kyle-ssg and removed request for a team January 8, 2025 13:44
@github-actions github-actions bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4979 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4979 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4979 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4979 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4979 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4979 Finished ✅ Results

@matthewelwell matthewelwell merged commit 8dc612f into main Jan 8, 2025
55 checks passed
@matthewelwell matthewelwell deleted the ci/fix-frontend-deploy-workflow branch January 8, 2025 13:47
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (7b58be6) to head (9c57396).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4979   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1191     1191           
  Lines       41630    41630           
=======================================
  Hits        40546    40546           
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build, test and deployment related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants